Added zero, iszero, one, isone to dual #74
Conversation
|
Cool, thanks for the contribution. Could you add tests? |
src/dual.jl
Outdated
| @@ -189,6 +189,17 @@ Base.ceil( ::Type{T}, z::Dual) where {T<:Real} = ceil( T, value(z)) | |||
| Base.trunc(::Type{T}, z::Dual) where {T<:Real} = trunc(T, value(z)) | |||
| Base.round(::Type{T}, z::Dual) where {T<:Real} = round(T, value(z)) | |||
|
|
|||
| Base.zero(::Type{Dual{T}}) where {T} = Dual(zero(T), zero(T)) | |||
| Base.zero(x::Dual{T}) where {T} = zero(T) | |||
| Base.iszero(z::Dual{T}) where {T} = iszero(value(z)) & iszero(epsilon(z)) | |||
There was a problem hiding this comment.
Is there a reason not to use short-circuiting && here and for isone?
src/dual.jl
Outdated
| @@ -189,6 +189,17 @@ Base.ceil( ::Type{T}, z::Dual) where {T<:Real} = ceil( T, value(z)) | |||
| Base.trunc(::Type{T}, z::Dual) where {T<:Real} = trunc(T, value(z)) | |||
| Base.round(::Type{T}, z::Dual) where {T<:Real} = round(T, value(z)) | |||
|
|
|||
| Base.zero(::Type{Dual{T}}) where {T} = Dual(zero(T), zero(T)) | |||
| Base.zero(x::Dual{T}) where {T} = zero(T) | |||
| Base.iszero(z::Dual{T}) where {T} = iszero(value(z)) & iszero(epsilon(z)) | |||
There was a problem hiding this comment.
This definition of iszero is inconsistent with how == 0 is defined for duals:
Line 167 in 52a6061
src/dual.jl
Outdated
| @@ -189,6 +189,17 @@ Base.ceil( ::Type{T}, z::Dual) where {T<:Real} = ceil( T, value(z)) | |||
| Base.trunc(::Type{T}, z::Dual) where {T<:Real} = trunc(T, value(z)) | |||
| Base.round(::Type{T}, z::Dual) where {T<:Real} = round(T, value(z)) | |||
|
|
|||
| Base.zero(::Type{Dual{T}}) where {T} = Dual(zero(T), zero(T)) | |||
| Base.zero(x::Dual{T}) where {T} = zero(T) | |||
There was a problem hiding this comment.
Why should these two versions of zero return different types?
| @@ -189,6 +189,21 @@ Base.ceil( ::Type{T}, z::Dual) where {T<:Real} = ceil( T, value(z)) | |||
| Base.trunc(::Type{T}, z::Dual) where {T<:Real} = trunc(T, value(z)) | |||
| Base.round(::Type{T}, z::Dual) where {T<:Real} = round(T, value(z)) | |||
|
|
|||
| Base.zero(::Type{Dual{T}}) where {T} = Dual(zero(T), zero(T)) | |||
| Base.zero(x::Dual{T}) where {T} = zero(typeof(x)) | |||
There was a problem hiding this comment.
Why not
| Base.zero(x::Dual{T}) where {T} = zero(typeof(x)) | |
| Base.zero(::Dual{T}) where {T} = zero(Dual{T}) |
| @@ -3,6 +3,7 @@ using Test | |||
| using LinearAlgebra | |||
| import DualNumbers: value | |||
| import NaNMath | |||
| import Base: one, isone, zero, iszero | |||
There was a problem hiding this comment.
These are exported from base, so this is unnecessary.
| import Base: one, isone, zero, iszero |
There was a problem hiding this comment.
You need to explicitly import it to extend it. Try this.
struct ABC end
one(x::ABC) = 1
Will give you the error
ERROR: error in method definition: function Base.one must be explicitly imported to be extended
Stacktrace:
[1] top-level scope at none:0
There was a problem hiding this comment.
I know that, but they are not being extended in the tests.
Co-Authored-By: Benoit Pasquier <[email protected]>
No description provided.