Skip to content

Commit

Permalink
fix: isless broken for mixed types (#73)
Browse files Browse the repository at this point in the history
Fixes #72.
  • Loading branch information
briochemc authored and ararslan committed Feb 7, 2019
1 parent 9801c7f commit 52a6061
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/dual.jl
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ Base.isequal(z::Dual, w::Dual) = isequal(value(z),value(w)) && isequal(epsilon(z
Base.isequal(z::Dual, x::Number) = isequal(value(z), x) && isequal(epsilon(z), zero(x))
Base.isequal(x::Number, z::Dual) = isequal(z, x)

Base.isless(z::Dual{T},w::Dual{T}) where {T<:Real} = value(z) < value(w)
Base.isless(z::Dual{<:Real},w::Dual{<:Real}) = value(z) < value(w)
Base.isless(z::Real,w::Dual{<:Real}) = z < value(w)
Base.isless(z::Dual{<:Real},w::Real) = value(z) < w

Expand Down
2 changes: 2 additions & 0 deletions test/automatic_differentiation_test.jl
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ y = sin(x)+exp(x)
@test epsilon(y) cos(2)+exp(2)

@test x > 1
@test dual(1) < dual(2.0)
@test dual(1.0) < dual(2.0)
y = abs(-x)
@test value(y) 2.0
@test epsilon(y) 1.0
Expand Down

0 comments on commit 52a6061

Please sign in to comment.