Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gadget2 read and units #8

Merged
merged 11 commits into from
Oct 29, 2021
Merged

Fix Gadget2 read and units #8

merged 11 commits into from
Oct 29, 2021

Commits on Oct 26, 2021

  1. Typos

    @elehcim
    elehcim committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    0a85339 View commit details
    Browse the repository at this point in the history

  2. Use StructArray properly

    @elehcim
    elehcim committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    de15f14 View commit details
    Browse the repository at this point in the history

  3. Convenience function to read only a file header

    @elehcim
    elehcim committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    4b89d1b View commit details
    Browse the repository at this point in the history

  4. Fix EOF error 

    when trying to read past the file to identify new blocks
    @elehcim
    elehcim committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    a1a5537 View commit details
    Browse the repository at this point in the history

  5. Use uGadget2 set of units 

    Do not convert data
    @elehcim
    elehcim committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    5a3c3eb View commit details
    Browse the repository at this point in the history

  6. Potential in energy unit per unit mass

    @elehcim
    elehcim committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    9737484 View commit details
    Browse the repository at this point in the history

  7. Fix mass and density reading

    @elehcim
    elehcim committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    fc323a9 View commit details
    Browse the repository at this point in the history

  8. add tests

    @elehcim
    elehcim committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    2ff135b View commit details
    Browse the repository at this point in the history

  9. register Gadget unit and add test

    @elehcim
    elehcim committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    18e23f6 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2021

  1. no need to filter on GAS particles

    @elehcim
    elehcim committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    c14ed9c View commit details
    Browse the repository at this point in the history

  2. Add test on filter on particle Collection using getingex 

    Related to: JuliaAstroSim/PhysicalParticles.jl#22
    @elehcim
    elehcim committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    ab380b9 View commit details
    Browse the repository at this point in the history