Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overload getindex to select particle type via Collection field #22

Merged
merged 3 commits into from
Oct 28, 2021

Conversation

elehcim
Copy link
Contributor

@elehcim elehcim commented Oct 27, 2021

No description provided.

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #22 (4de76f8) into master (7101faa) will increase coverage by 0.13%.
The diff coverage is 100.00%.

❗ Current head 4de76f8 differs from pull request most recent head c7a9461. Consider uploading reports for the commit c7a9461 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   85.83%   85.97%   +0.13%     
==========================================
  Files          13       13              
  Lines         713      720       +7     
==========================================
+ Hits          612      619       +7     
  Misses        101      101              
Impacted Files Coverage Δ
src/Unit.jl 98.52% <ø> (ø)
src/PVector.jl 99.09% <100.00%> (+0.02%) ⬆️
src/PhysicalParticle.jl 75.40% <100.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bb5227...c7a9461. Read the comment docs.

@islent islent merged commit cc9dbda into JuliaAstroSim:master Oct 28, 2021
elehcim added a commit to elehcim/AstroIO.jl that referenced this pull request Oct 29, 2021
islent pushed a commit to JuliaAstroSim/AstroIO.jl that referenced this pull request Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants