Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Julia 0.7 #20

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Update to Julia 0.7 #20

merged 1 commit into from
Jul 2, 2018

Conversation

timholy
Copy link
Member

@timholy timholy commented Jul 2, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 2, 2018

Codecov Report

Merging #20 into master will increase coverage by 6.38%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #20      +/-   ##
========================================
+ Coverage   93.61%   100%   +6.38%     
========================================
  Files           1      1              
  Lines          47     35      -12     
========================================
- Hits           44     35       -9     
+ Misses          3      0       -3
Impacted Files Coverage Δ
src/MappedArrays.jl 100% <100%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c94b67a...6a91ea3. Read the comment docs.

@@ -1 +1 @@
julia 0.6
julia 0.7-alpha
Copy link
Member

@Evizero Evizero Jul 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just out of curiousity since I saw this line at another package as well: whats the difference/benefit over?

julia 0.7-

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested, but I was assuming (based on past experience, I think) that 0.7- would mean 0.7.0 and upward. Since that hasn't been released yet there would be a version error.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also asked on slack after this. The answer i got from the helpdesk channel was that while technically julia 0.7- does include all pre-releases, it does not work well with Femtocleaner.

@timholy timholy merged commit a03e5f3 into master Jul 2, 2018
@timholy timholy deleted the teh/v07 branch July 2, 2018 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants