Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for 0.7 #18

Closed
wants to merge 2 commits into from
Closed

fixes for 0.7 #18

wants to merge 2 commits into from

Conversation

rened
Copy link

@rened rened commented Mar 27, 2018

tests pass on 0.6 and 0.7 without warnings

@codecov-io
Copy link

codecov-io commented Mar 27, 2018

Codecov Report

Merging #18 into master will increase coverage by 31.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #18       +/-   ##
=========================================
+ Coverage   68.96%   100%   +31.03%     
=========================================
  Files           1      1               
  Lines          29     20        -9     
=========================================
  Hits           20     20               
+ Misses          9      0        -9
Impacted Files Coverage Δ
src/MappedArrays.jl 100% <100%> (+31.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a9f5bc...fe66957. Read the comment docs.

@timholy
Copy link
Member

timholy commented Jul 2, 2018

Thanks for this! Sorry I didn't see this when it was timely.

Back when you submitted this and 0.7 was distant, maintaining compatibility with 0.6 was the right strategy. Now that 0.7 is in beta release, I am not trying to be compatible with older Julia releases. 0.7 will be the same as 1.0, minus deprecations, so we'd have to strip out all the Compat code anyway. I merged #20. If you want to add the Project.toml as a separate PR, please do, although https://discourse.julialang.org/t/pkg3-plan-and-status/9763 suggests there will be an automatic migration at some point.

Again, sincere apologies for not having seen this when it might have been the right thing to do.

@timholy timholy closed this Jul 2, 2018
@rened
Copy link
Author

rened commented Jul 4, 2018

No worries at all ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants