-
Notifications
You must be signed in to change notification settings - Fork 115
Long-running PR for v2.0 of the content directory #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pioneer: Apps adjustments + joy-members reactivation
substrate 2.0.0-rc4 version upgrade
This reverts commit f22c380.
Substrate version upgrade into iznik branch (Alexandria)
…tIndex Colossus - accountNextIndex() instead of nonce caching
…sal type & related logic
…sal type related logic
Content directory runtime integration
Colossus/route to ipfs gateway
Content directory second try
…to proposal_codex_upgrade
Merge latest Iznik changes
…akingEventsHandler & StorageWgStakingEventsHandler
…tent_directory_schema_refactoring
Proposal codex upgrade
…oring Content directory schema refactoring: move property related logic to separate file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long-running PR for v2.0 of the content directory
VLOS
https://github.com/Joystream/joystream-landing/issues/175
Drop all events in VLOS
Enforce unique class names. <= Why? perhaps we should even drop them?
Enforce unique property names within each class. <= Why? perhaps we should even drop them?
Rename
PropertyType::InternaltoPropertyType::Reference, and same forPropertyValue::Internal, as we are dropping the no'tion of external references.Remove
PropertyType::None, was added to have some value for required Default trait, but has no semantic content. Instead just return some other value needed, we should not sacrifice our type safety due to a bad Substrate design decision.Remove
Class::idandEntity::id, as per convention Fix test for storage module and add new #36 (comment).Make
ClassIdandEntityId, configurable through runtime.Raw index types u16 are used for index types, replace with aliases for each use case, e.g.
ClassId,EntityId,PropertyIdetc. for clarity. Also make publicAdd boolean field in
ClassSchemawhich indicates whether a schema is active or not. It is only possible to add schema support to an entity for an active schema. Introduce method for updating this status also.ClassSchema->SchemaChange values field of Entity to
BTreeMap<u16, PropertyValue>where key is index of property in class, and killClassPropertyValue.Change
in_class_schema_indexesinEntitytoBTreeSet, and give better name to field, likesupported_schemas.Make vector properties updatable as vectors substrate-versioned-store-module#13
Entity removal substrate-versioned-store-module#22
Drop from storage these from storage, they need not be tuneable at runtime, just make them configurable through runtime trait.
paritytech/substrate#3263 - is not implemented yet
Remove
InputValidationLengthConstraint, as it is no longer needed.Introduce a new trait for Module, so that other modules depending on VLOS can consume this trait on runtime, which also allows for mocking.
Proposal: Merge permission and version store #380
Merge permission and version store
ClassandClassPermission, only have one instance per class, and only one mapEntityandEntityPermission, only have one instance per entity, and only one map.Drop
ClassPermission::properties_locked_from_controller, and instead enrichPropertyTypeto include a locking flag for controllers.Drop
ClassPermission::properties_locked_from_maintainers, and instead enrichPropertyTypeto include a locking flag for maintainers.Drop
ClassPermission::referenced_entity_must_have_same_controller, and instead enrichPropertyType::Referenceto include a same owner boolean flag.VLOS Permissions
https://github.com/Joystream/joystream-landing/issues/178
Security/configuration constraints for:
Closes Proposal: Merge permission and version store #380, Proposal: Efficient entity ownership transfer #379, Content directory: introduce events for all extrinsics #453
Resolves Make vector properties updatable as vectors substrate-versioned-store-module#13, resolves Entity removal substrate-versioned-store-module#22