Skip to content

Conversation

@Lezek123
Copy link
Contributor

@Lezek123 Lezek123 commented Aug 12, 2020

Implements:

Changes:

  • Adjusted styles and functionality of the new polkadot-js/apps based on our old, modified apps (ie. added providers in Apps, added our types to api, added TopBar with account dropdown-select, adjusted the routes/tabs). I tried to limit the amout of those changes to the absolute minimum.
  • Partially re-activated joy-utils. Moved all required functionality to new joy-utils directory, did some refactoring and put the files inside a new, more clean directory structure.
  • Reactivated joy-members and joy-pages and did all the necessary adjustments.
  • Disabled some linter rules that could cause too much chaos during the upgrade
  • Fixed remaining linter issues

Draft:
Based on: #1101
Merged #1153 for new node compatibility

Commits of intrest:

Testing:

  1. Run dev chain based on fb9845b (currently should already be part of https://github.com/Joystream/joystream/tree/substrate_version_upgrade)
  2. yarn workspace pioneer start or use deploy preview at https://deploy-preview-1156--joystream-pioneer.netlify.app/
  3. Change endpoint to local node (ie. by clicking the Joystream logo in the top-left corner)

@Lezek123 Lezek123 marked this pull request as draft August 12, 2020 13:32
@Lezek123
Copy link
Contributor Author

Lezek123 commented Aug 14, 2020

  • Added gtag for production environment (which was also present before the upgrade)
  • Fixed Semantic UI Icons (they were not displayed due to Semantic UI fonts beeing ignored by the new webapack.base.config)
  • Some minor style corrections (more suitable TxButton default icon, Council badge fix on members list)

@mnaamani
Copy link
Member

perhaps you could merge iznik to make the PR cleaner to see the changes?

@Lezek123 Lezek123 requested a review from mnaamani August 17, 2020 09:06
@Lezek123
Copy link
Contributor Author

Added back "Staking" (Validators) tab which I accidently excluded.
Did some testing - didn't encounter any significant issues (just fixed one minor UI glitch)

@Lezek123 Lezek123 marked this pull request as ready for review August 20, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants