Introduce video state bloat bond #3833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
L3pereira
changed the title
L3pereira
added
enhancement
bedeho
reviewed
Jun 3, 2022
| // == MUTATION SAFE == | ||
| // | ||
|
|
||
| let _ = Balances::<T>::slash(&sender, video_state_bloat_bond); |
Member
There was a problem hiding this comment.
Do we not put the bloat bond in some treasury account or something? What did we do for bounty pallet bloat bonds, or for storage?
dobertRowneySr
suggested changes
Jun 3, 2022
Collaborator
dobertRowneySr
left a comment
dobertRowneySr
left a comment
There was a problem hiding this comment.
Same cosmetics as the channel bloat bond PR, otherwise LGTM
| increase_account_balance_helper(DEFAULT_MEMBER_ACCOUNT_ID, 11); | ||
| create_default_member_owned_channel(); | ||
|
|
||
| let video_state_bloat_bond = 1; |
Collaborator
There was a problem hiding this comment.
why not use their DEFAULT-* counterparts?
dobertRowneySr
approved these changes
Jun 27, 2022
L3pereira
force-pushed
the
introduce_video_state_bloat_bond_#3394
branch
from
054225d to
0e07683
Compare
dobertRowneySr
suggested changes
Jun 30, 2022
Collaborator
There was a problem hiding this comment.
- build node & runtime ✔️
- types and metadata ✔️
- cargo test ✔️
- there are some problem with benchmarks:
---- tests::council_discard_remaining_rewards_on_depose stdout ----
thread 'tests::council_discard_remaining_rewards_on_depose' panicked at 'attempt to subtract with overflow', runtime-modules/council/src/mock.rs:1496:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
---- tests::council_many_cycle_rewards stdout ----
thread 'tests::council_many_cycle_rewards' panicked at 'attempt to subtract with overflow', runtime-modules/council/src/mock.rs:1496:17
---- tests::council_rewards_are_paid stdout ----
thread 'tests::council_rewards_are_paid' panicked at 'attempt to subtract with overflow', runtime-modules/council/src/mock.rs:1496:17
---- tests::vote_stake_locks_after_new_election_starts stdout ----
thread 'tests::vote_stake_locks_after_new_election_starts' panicked at 'attempt to subtract with overflow', runtime-modules/council/src/mock.rs:1496:17
These should be fixed see mnaamani#13
L3pereira
force-pushed
the
introduce_video_state_bloat_bond_#3394
branch
from
0e07683 to
7e8982d
Compare
types generation types generation and channel duplication fix
L3pereira
force-pushed
the
introduce_video_state_bloat_bond_#3394
branch
from
7e8982d to
375f94f
Compare
dobertRowneySr
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #3821
When creating a video, the sender gets slashed video state bloat bond
When deleting a channel sender gets paid the video state bloat bond amount
Uses the funds_needed_for_upload implemented here #3693 to verify the funds needed before charging the video state bloat bond
┆Issue is synchronized with this Asana task by Unito