introduce_channel_state_bloat_bond

[L3pereira]

• Closes Protect channel account dusting: introduce channel state bloat bond #3511

When creating a channel, the sender gets slashed channel state bloat bond
When deleting a channel sender gets paid the channel state bloat bond amount
Uses the funds_needed_for_upload implemented here #3693 to verify the funds needed before charging
the channel state bloat bond

┆Issue is synchronized with this Asana task by Unito

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
pioneer-testnet	⬜️ Ignored (Inspect)		Jul 1, 2022 at 9:00AM (UTC)

[bedeho]

Do we not credit the bloat bond to some treasury account? I don't actually remember, what do we do for bounties or in the storage pallet?

[L3pereira]

Yes, we credited to StorageTreasury, in bounties we had a Council Budget, that's why I got confused about using content workgroup budget account instead of simply the sender's account. Since, for example, channel transfer uses the budget or the sender based on which type is the owner.
I implemented with an imbalance, and always used the sender's account, the reason I didn't use the storage treasury, was I thought we wanted to move this logic away from the storage pallet
In my opinion, we should use the following (I implemented this way at first, but then I step back since it was not clear to me if I should use it)
Lead -> Senders account
Memeber - > Senders account
Curator Group -> Content working group budget
We should also break the functions that transfer funds so they do not fail, as we did in bounties

[dobertRowneySr]

Cosmetics, otherwise LGTM. Good job!

[dobertRowneySr]

LGTM

[dobertRowneySr]

• build node & runtime ✔️
• types and metadata ✔️
• cargo test ✔️
• there are some problem with benchmarks:

---- tests::council_discard_remaining_rewards_on_depose stdout ----
thread 'tests::council_discard_remaining_rewards_on_depose' panicked at 'attempt to subtract with overflow', runtime-modules/council/src/mock.rs:1496:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- tests::council_many_cycle_rewards stdout ----
thread 'tests::council_many_cycle_rewards' panicked at 'attempt to subtract with overflow', runtime-modules/council/src/mock.rs:1496:17

---- tests::council_rewards_are_paid stdout ----
thread 'tests::council_rewards_are_paid' panicked at 'attempt to subtract with overflow', runtime-modules/council/src/mock.rs:1496:17

---- tests::vote_stake_locks_after_new_election_starts stdout ----
thread 'tests::vote_stake_locks_after_new_election_starts' panicked at 'attempt to subtract with overflow', runtime-modules/council/src/mock.rs:1496:17

These should be fixed see mnaamani#13