Skip to content

Conversation

@shamil-gadelshin
Copy link
Contributor

@shamil-gadelshin shamil-gadelshin commented Mar 27, 2020

Features

Proposals

  • Spending proposal
  • Set CM Mint Capacity proposal
  • Set Lead proposal
  • Set WG Mint Capacity proposal
  • Set Council Parameters proposal

Integrations

  • stake module fixes
  • latest runtime monorepo upgrade with full-node
  • module runtime integration tests

Miscellaneous

  • cancellation, rejection fees tests
  • council reelection hooks
  • missing tests for decl_error! macro errors
  • numerous refactorings and improved comments
  • removing proposals v1 from node config

mnaamani and others added 30 commits February 25, 2019 21:27
fixes issue with processing transactions of illiquid accounts
update runtime dependency to come from new repo
mnaamani and others added 10 commits March 27, 2020 21:20
- add CouncilElected hook for the proposals
- remove unused error.rs
- add some comments
- add reset_active_proposals() and tests
- add runtime integration test proposal_reset_succeeds()
# Conflicts:
#	runtime-modules/governance/src/lib.rs
- add ‘set_election_parameters’ extrinsic
- add tests
- add check for correct proposal type for other extrinsics
# Conflicts:
#	node/src/chain_spec.rs
#	runtime-modules/governance/src/proposals.rs
#	runtime/src/lib.rs
@shamil-gadelshin shamil-gadelshin linked an issue Mar 30, 2020 that may be closed by this pull request
- add create_set_content_working_group_mint_capacity_proposal() extrinsic to the codex module
- add tests
- refactor codex module tests
- add ‘spending proposal’ extrinsic to the codex module
- add tests
@shamil-gadelshin shamil-gadelshin linked an issue Mar 31, 2020 that may be closed by this pull request
- add ‘create_set_lead_proposal()’ extrinsic in the codex module
- add tests
@shamil-gadelshin shamil-gadelshin linked an issue Apr 1, 2020 that may be closed by this pull request
@shamil-gadelshin shamil-gadelshin requested a review from bedeho April 1, 2020 09:46
@shamil-gadelshin shamil-gadelshin marked this pull request as ready for review April 1, 2020 09:47
@bedeho
Copy link
Member

bedeho commented Apr 2, 2020

Yeah this was very hard to review on Github due to the commit history.

What if we pull in recent changes into the proposal_v2, and then we can rebase proposal_v2_iteration7. Alternatively, something else?

# Conflicts:
#	.travis.yml
#	runtime-modules/governance/src/lib.rs
#	runtime-modules/governance/src/proposals.rs
#	runtime/src/lib.rs
…iteration7

# Conflicts:
#	Cargo.lock
#	runtime-modules/proposals/codex/Cargo.toml
#	runtime-modules/proposals/engine/src/tests/mock/balance_manager.rs
@shamil-gadelshin
Copy link
Contributor Author

shamil-gadelshin commented Apr 6, 2020

Superseded byhttps://github.com//pull/264

bedeho pushed a commit that referenced this pull request May 29, 2020
@shamil-gadelshin shamil-gadelshin deleted the proposals_v2_iteration7 branch June 25, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment