-
Notifications
You must be signed in to change notification settings - Fork 115
Proposals version 2. Iteration 7 #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
shamil-gadelshin
wants to merge
444
commits into
Joystream:proposals_v2
from
shamil-gadelshin:proposals_v2_iteration7
Closed
Proposals version 2. Iteration 7 #254
shamil-gadelshin
wants to merge
444
commits into
Joystream:proposals_v2
from
shamil-gadelshin:proposals_v2_iteration7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memo module
proposal veto
live testnet 1
improved readme
fixes issue with processing transactions of illiquid accounts
Runtime spec 4
updated readme
update runtime dependency to come from new repo
- add CouncilElected hook for the proposals - remove unused error.rs - add some comments - add reset_active_proposals() and tests - add runtime integration test proposal_reset_succeeds()
# Conflicts: # runtime-modules/governance/src/lib.rs
- add ‘set_election_parameters’ extrinsic - add tests - add check for correct proposal type for other extrinsics
Docs for set_election_parameters
Add a council mint
# Conflicts: # node/src/chain_spec.rs # runtime-modules/governance/src/proposals.rs # runtime/src/lib.rs
This was
linked to
issues
Mar 30, 2020
- add create_set_content_working_group_mint_capacity_proposal() extrinsic to the codex module - add tests - refactor codex module tests
- add ‘spending proposal’ extrinsic to the codex module - add tests
- add ‘create_set_lead_proposal()’ extrinsic in the codex module - add tests
Member
|
Yeah this was very hard to review on Github due to the commit history. What if we pull in recent changes into the |
# Conflicts: # .travis.yml # runtime-modules/governance/src/lib.rs # runtime-modules/governance/src/proposals.rs # runtime/src/lib.rs
…iteration7 # Conflicts: # Cargo.lock # runtime-modules/proposals/codex/Cargo.toml # runtime-modules/proposals/engine/src/tests/mock/balance_manager.rs
Contributor
Author
|
Superseded byhttps://github.com//pull/264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Proposals
SpendingproposalSet CM Mint CapacityproposalSet LeadproposalSet WG Mint CapacityproposalSet Council ParametersproposalIntegrations
Miscellaneous
decl_error!macro errors