Pioneer: joy-roles upgrade #1179
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 25 commits
August 12, 2020 11:01
Lezek123
force-pushed
the
joy-roles-upgrade
branch
from
ff67c38 to
a9e4448
Compare
Contributor
Author
|
Covered by #1195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements:
Changes:
joy-utilsjoy-rolesjoy-utilsto avoid unnecessary re-renders that could lead to loss of data in the forms, problems when resizing the page and generally poor UX and optimalization. The main issue was that custom "render functions" were used in a few places instead of standard React components. When those functions were called after some state update - everything that they previously rendered was getting re-rendered from scratch and all the previous state in child components was lost.anytype)jestavailable again which allows runningyarn workspace @polkadot/joy-roles test, addedgenerate:json-schemasscripting in@joystream/typesto allow updatinghiring/schemas/role.schema.json, configured webapck to handle.scssfiles, added backtsconfig-paths-webpack-pluginto allow running storybook in the future)I ignored the storybook files that already had
ts-nocheck, the rest of the files I tried to upgrade as the cost wasn't very high. That means that a few of the stories will probably work and the rest can be updated later if needed. Currently the storybook fails because not all packages are upgraded yet (ie.joy-media), but I'll try to make it usable at the end of upgrading Pioneer.Draft:
Based on: #1176 with #1177 merged (for a few additional types exposed in the registry)