-
Notifications
You must be signed in to change notification settings - Fork 116
Description
At this point joy-proposals should be already enabled which should make testing hiring scenarios and spotting any potential issues much easier. My familiarity with joy-roles package and the experience gained from upgrading joy-proposals (step 6) should also help in making the upgrade of this package go relatively smoothly at this point.
I'm predicting that this package is going to go through one of the biggest reworks (along with joy-media) w.r.t. the planned upgrades, as it intensely uses linked maps, new SomeType() constructs and other @joystream/types and @polkadot/api related "features" that may not be preserved.
It may turn out that a huge part of the required adjustments is going to revolve around the mocks and storybook, in which case I think a resonable solution would be to throw those away completely. Most of the joy-roles storybook is already outdated anyway and does no longer work, so keeping it and trying to implement all the required adjustments doesn't really seem justified (we can consider rewriting it when needed in the future. This should also be way easier once we have a complete, normalized mock-transport, possibly implemented in joy-utils)
While working on this issue and #1045 I'll try to keep in mind that at some point (probably not yet due to complications related to content-working-group inconsistency with other working groups), both joy-proposals and joy-roles transports should be merged inside joy-utils. It may make sense to try to normalize them to the point that makes this transition go as smoothly as possible in the future.