Skip to content

Conversation

@Lezek123
Copy link
Contributor

@Lezek123 Lezek123 commented Aug 11, 2020

Updated @joystream/types following the AccountInfo type rename in the runtime (to StorageProviderAccountInfo): e01eb1c

The reason this rename was introduced is because the AccountInfo type name was colliding with one the new Substrate core types (see: https://github.com/polkadot-js/api/blob/master/packages/types/src/interfaces/system/types.ts).

I also fixed yarn.lock which seemed outdated on the current iznik branch and was causing some dependency issues.

@Lezek123 Lezek123 requested a review from mnaamani August 11, 2020 11:30
@Lezek123
Copy link
Contributor Author

Since the yarn.lock fix wasn't enough, because the issue was still present during npm pack CI check, I changed @polkadot dependencies to exact versions to prevent incompatible versions like 1.28.1 from beeing installed.

@mnaamani
Copy link
Member

FYI: I suggested a better name for the renamed AccountInfo #1148 (comment)

@Lezek123
Copy link
Contributor Author

Added types required by the node after fb9845b

  Address: 'AccountId',
  LookupSource: 'AccountId',

Confirmed that this solves the issue with extrinsics discussed in #1126

@Lezek123 Lezek123 changed the title @joystream/types: Rename AccountInfo and fix yarn.lock @joystream/types: Rename AccountInfo, make dependencies exact, add types required by new node Aug 12, 2020
@Lezek123
Copy link
Contributor Author

Changed the name from StorageProviderAccountInfo to ServiceProviderRecord because of expected rename in the runtime.

@mnaamani mnaamani merged commit 4a7268f into Joystream:iznik Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants