Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags per page #318

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Tags per page #318

merged 3 commits into from
Jun 5, 2023

Conversation

Vulwsztyn
Copy link
Contributor

@Vulwsztyn Vulwsztyn commented May 29, 2023

closes #315

README.md Outdated Show resolved Hide resolved
Copy link
Owner

@Joxit Joxit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there and thank you for your contribution!

I think I prefer TAGLIST_TAGS_PER_PAGE or TAGLIST_PAGE_SIZE. What do you think ? (I'm trying to prepend the option with the targeted page, CATALOG_/TAGLIST_/HISTORY_)

You need to update this file

sed -i "s~\${CATALOG_DEFAULT_EXPANDED}~${CATALOG_DEFAULT_EXPANDED}~" index.html

And add (replace with your favourite configuration name

sed -i "s~\${TAGLIST_PAGE_SIZE}~${TAGLIST_PAGE_SIZE}~" index.html

You can rebase your branch since I've merge your other PR 😄

README.md Outdated Show resolved Hide resolved
src/components/tag-list/tag-table.riot Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
@Joxit Joxit added this to the 2.5.0 milestone May 31, 2023
@Joxit Joxit self-assigned this May 31, 2023
@Joxit
Copy link
Owner

Joxit commented Jun 2, 2023

Hi there, did you have time to see my #318 (review) and edit docker-registry-ui/bin/90-docker-registry-ui.sh and the environment name ?

You can also rebase your PR with the new main branch

@Vulwsztyn
Copy link
Contributor Author

Yo, done what you asked for

Copy link
Owner

@Joxit Joxit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Joxit Joxit merged commit 9cfb679 into Joxit:main Jun 5, 2023
@Joxit
Copy link
Owner

Joxit commented Jun 5, 2023

Thank you for your contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Sorting only sorts the tags on the current page and not the whole list of tags
2 participants