-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tags per page #318
Tags per page #318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there and thank you for your contribution!
I think I prefer TAGLIST_TAGS_PER_PAGE
or TAGLIST_PAGE_SIZE
. What do you think ? (I'm trying to prepend the option with the targeted page, CATALOG_/TAGLIST_/HISTORY_)
You need to update this file
docker-registry-ui/bin/90-docker-registry-ui.sh
Lines 15 to 16 in d2e6cdc
sed -i "s~\${CATALOG_DEFAULT_EXPANDED}~${CATALOG_DEFAULT_EXPANDED}~" index.html | |
And add (replace with your favourite configuration name
sed -i "s~\${TAGLIST_PAGE_SIZE}~${TAGLIST_PAGE_SIZE}~" index.html
You can rebase your branch since I've merge your other PR 😄
Hi there, did you have time to see my #318 (review) and edit docker-registry-ui/bin/90-docker-registry-ui.sh and the environment name ? You can also rebase your PR with the new |
Yo, done what you asked for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for your contribution 🎉 |
closes #315