Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting only sorts the tags on the current page and not the whole list of tags #315

Closed
Vulwsztyn opened this issue May 26, 2023 · 1 comment · Fixed by #318
Closed

Sorting only sorts the tags on the current page and not the whole list of tags #315

Vulwsztyn opened this issue May 26, 2023 · 1 comment · Fixed by #318

Comments

@Vulwsztyn
Copy link
Contributor

Vulwsztyn commented May 26, 2023

Is your feature request related to a problem? Please describe.
the sorting of tags with paginated tags is done only per page and not globally. If you want to find the latest tag you need to go over all the pages instead of just sorting by creation time on the 1st page.

Describe the solution you'd like
Add a variable that changes that behaviour to preloading all image tags (I know this only makes sense for relatively low number of pages) and sorting on them all instead of on jsut he page

Describe alternatives you've considered
Add a variable that disables pagination and shows all tags on one page.

Additional context

@Joxit
Copy link
Owner

Joxit commented May 28, 2023

Hi, thank you for using my project and posting feature requests.

Unfortunately, sorting by column other than tags is only possible in a per page basis.

As you said this makes sense only on low number of pages. IMO the risk is much bigger than the benefits in that case. When you have pages, that means you actually have a lot of images and the number will grow with time.
This feature will create one request by tag, so if you have 1000 tags, it will create 1000 requests just for sorting your images and that's too much.
If we say we limit to a specific amount, the feature will work until that amount and the user will not understand why it doesn't work anymore...

From your alternate solution instead of deactivating the pagination I might configure it, like x images by pages.

IDK if I can do it with docker registry server though

This was referenced Jun 1, 2023
@Joxit Joxit closed this as completed in #318 Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants