Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug: npx create-typescript-app is failing #1253

Closed
3 tasks done
DemianParkhomenko opened this issue Jan 16, 2024 · 6 comments 路 Fixed by #1256
Closed
3 tasks done

馃悰 Bug: npx create-typescript-app is failing #1253

DemianParkhomenko opened this issue Jan 16, 2024 · 6 comments 路 Fixed by #1256
Assignees
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@DemianParkhomenko
Copy link
Contributor

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

I run the command and magic setup is here.

Actual


node:internal/errors:497
    ErrorCaptureStackTrace(err);
    ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'rimraf' imported from /Users/demian/.npm/_npx/4aa729db9999bfc4/node_modules/create-typescript-app/lib/steps/runCleanup.js
    at new NodeError (node:internal/errors:406:5)
    at packageResolve (node:internal/modules/esm/resolve:789:9)
    at moduleResolve (node:internal/modules/esm/resolve:838:20)
    at defaultResolve (node:internal/modules/esm/resolve:1043:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:383:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:352:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:228:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:85:39)
    at link (node:internal/modules/esm/module_job:84:36) {
  code: 'ERR_MODULE_NOT_FOUND'
}

Node.js v20.8.1
Screen.Recording.2024-01-16.at.23.31.56.mov

Additional Info

No response

@DemianParkhomenko DemianParkhomenko added the type: bug Something isn't working :( label Jan 16, 2024
@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! label Jan 16, 2024
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @DemianParkhomenko for bug.

馃 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 馃挋

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @DemianParkhomenko! 馃帀

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

JoshuaKGoldberg pushed a commit that referenced this issue Jan 16, 2024
Adds @DemianParkhomenko as a contributor for bug.

This was requested by JoshuaKGoldberg [in this
comment](#1253 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@JoshuaKGoldberg
Copy link
Owner

Thanks for filing @DemianParkhomenko! For context, Demian mentioned this in the Twitch chat in my stream today.

Since this is a pretty significant "things are broken" I'm going to need to have it fixed within the next few hours. If you don't have time to finish up the PR by, say, 9pm EST (about 1.5 hours from now) could you please push what you have? Or if there's no code, an explanation of progress? I'd like to give you co-author attribution if possible 馃槃

@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 17, 2024
JoshuaKGoldberg added a commit that referenced this issue Jan 17, 2024
## PR Checklist

- [x] Addresses an existing open issue: fixes #1253
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [ ] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Switches `rimraf` from a `devDependency` to a full production
dependency. Whoops.
Copy link

馃帀 This is included in version v1.54.3 馃帀

The release is available on:

Cheers! 馃摝馃殌

@DemianParkhomenko
Copy link
Contributor Author

If you don't have time to finish up the PR by, say, 9pm EST (about 1.5 hours from now) could you please push what you have?

Ah, sorry for making you wait. I said on Twitch (maybe the message was lost) that I doubted how to fix it, and I would profile an issue instead of PR.

@JoshuaKGoldberg
Copy link
Owner

Oh great! That's perfect - I just was worried about trampling over your work haha. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants