Skip to content

Commit

Permalink
fix: switch rimraf to full dependency (#1256)
Browse files Browse the repository at this point in the history
## PR Checklist

- [x] Addresses an existing open issue: fixes #1253
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [ ] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Switches `rimraf` from a `devDependency` to a full production
dependency. Whoops.
  • Loading branch information
JoshuaKGoldberg committed Jan 17, 2024
1 parent 1140275 commit 41ab495
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 21 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
"parse-author": "^2.0.0",
"prettier": "^3.1.0",
"replace-in-file": "^7.0.2",
"rimraf": "^5.0.5",
"title-case": "^4.1.2",
"zod": "^3.22.4",
"zod-validation-error": "^2.1.0"
Expand Down Expand Up @@ -99,7 +100,6 @@
"prettier-plugin-curly": "^0.1.3",
"prettier-plugin-packagejson": "^2.4.7",
"release-it": "^17.0.0",
"rimraf": "^5.0.5",
"sentences-per-line": "^0.2.1",
"should-semantic-release": "^0.2.1",
"tsup": "^8.0.1",
Expand Down
23 changes: 4 additions & 19 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/steps/uninstallPackages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ export async function uninstallPackages(offline: boolean | undefined) {
"js-yaml",
"npm-user",
"parse-author",
"rimraf",
"octokit",
"prettier",
"replace-in-file",
Expand All @@ -38,7 +39,6 @@ export async function uninstallPackages(offline: boolean | undefined) {
"c8",
"eslint-config-prettier",
"globby",
"rimraf",
"tsx",
],
packageData.devDependencies,
Expand Down

0 comments on commit 41ab495

Please sign in to comment.