Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Omitting PlayerMoveEvent #76

Merged
merged 3 commits into from
Apr 23, 2020
Merged

Allow Omitting PlayerMoveEvent #76

merged 3 commits into from
Apr 23, 2020

Commits on Apr 19, 2020

  1. No need to listen for PlayerKickEvent - quit event fires anyway 

    The PlayerQuitEvent is fired even when the player is kicked.
    @A248
    A248 committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    dfd916d View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2020

  1. Permit periodic task instead of PlayerMoveEvent through NPCLibOptions 

    Adds NPCLibOptions as an optional parameter to NPCLib's constructor. The
movement handling specified by the NPCLibOptions will determine whether
to use the PlayerMoveEvent or a task.
    @A248
    A248 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    b00850b View commit details
    Browse the repository at this point in the history

  2. Player#isOnline is not thread safe 

    CraftBukkit 1.8.8 implementation checks whether Bukkit.getPlayer(<player
uuid>) != null. Bukkit.getPlayer(UUID) is itself not thread safe.
    @A248
    A248 committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    b4ce4fb View commit details
    Browse the repository at this point in the history