Allow Omitting PlayerMoveEvent #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PlayerQuitEvent is fired even when the player is kicked.
Adds NPCLibOptions as an optional parameter to NPCLib's constructor. The movement handling specified by the NPCLibOptions will determine whether to use the PlayerMoveEvent or a task.
CraftBukkit 1.8.8 implementation checks whether Bukkit.getPlayer(<player uuid>) != null. Bukkit.getPlayer(UUID) is itself not thread safe.
|
Thanks for this PR! These are some great additions to the library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some programmers may not want to rely on the PlayerMoveEvent, since it fires very quickly and often, even for mere head-movement. As such, the main purpose of this PR adds
NPCLibOptions, which is a general wrapper for preferences passed to NPCLib.In the future more could be added to NPCLibOptions if desired. As it stands, however, the only parameter is movement handling, a.k.a.
NPCLibOptions.MovementHandling.The other 2 commits are self-explanatory. Note that I have tested and ensured that the PlayerQuitEvent is called regardless of whether it was caused by a kick (I used 1.8.8, but it wouldn't make any sense for this contract to change in future versions)