Fix compilation errors

[tylerlevine]

I was getting some compilation errors when building the checktemplateverify-feb1-workshop branch:

$ make
Making all in src
  CXX      wallet/libbitcoin_wallet_a-rpcwallet.o
wallet/rpcwallet.cpp:1139:97: error: expected body of lambda expression
    const auto cmp = [](const std::pair<double, CTxOut>& a, const std::pair<double, CTxOut>& b) bool {
                                                                                                ^
wallet/rpcwallet.cpp:1142:61: error: unknown type name 'vecSend'
    std::multiset<std::pair<double, CTxOut>, decltype(cmp)> vecSend(cmp);
                                                            ^
wallet/rpcwallet.cpp:1161:9: error: use of undeclared identifier 'vecSend'
        vecSend.emplace((sort_keys_it++)->first, recipient);
        ^
wallet/rpcwallet.cpp:1173:26: error: use of undeclared identifier 'vecSend'
        for (auto& txo : vecSend) {
                         ^
wallet/rpcwallet.cpp:1190:9: error: use of undeclared identifier 'vecSend'
        vecSend.clear();
        ^
wallet/rpcwallet.cpp:1198:9: error: use of undeclared identifier 'vecSend'
        vecSend.emplace(0, CTxOut(base.vout[0].nValue + base.vout[1].nValue, script));
        ^
wallet/rpcwallet.cpp:1203:16: error: use of undeclared identifier 'vecSend'
        while (vecSend.size() > 1) {
               ^
wallet/rpcwallet.cpp:1209:51: error: use of undeclared identifier 'vecSend'
            const size_t pieces = std::min(radix, vecSend.size());
                                                  ^
wallet/rpcwallet.cpp:1218:34: error: use of undeclared identifier 'vecSend'
                    auto start = vecSend.begin();
                                 ^
wallet/rpcwallet.cpp:1219:32: error: use of undeclared identifier 'vecSend'
                    auto end = vecSend.begin();
                               ^
wallet/rpcwallet.cpp:1222:21: error: use of undeclared identifier 'vecSend'
                    vecSend.erase(start, end);
                    ^
wallet/rpcwallet.cpp:1225:34: error: use of undeclared identifier 'vecSend'
                    auto start = vecSend.rbegin();
                                 ^
wallet/rpcwallet.cpp:1226:32: error: use of undeclared identifier 'vecSend'
                    auto end = vecSend.rbegin();
                               ^
wallet/rpcwallet.cpp:1229:21: error: use of undeclared identifier 'vecSend'
                    vecSend.erase(std::prev(start.base()), vecSend.end());
                    ^
wallet/rpcwallet.cpp:1229:60: error: use of undeclared identifier 'vecSend'
                    vecSend.erase(std::prev(start.base()), vecSend.end());
                                                           ^
wallet/rpcwallet.cpp:1232:30: error: use of undeclared identifier 'vecSend'
                auto start = vecSend.begin();
                             ^
wallet/rpcwallet.cpp:1233:28: error: use of undeclared identifier 'vecSend'
                auto end = vecSend.begin();
                           ^
wallet/rpcwallet.cpp:1236:17: error: use of undeclared identifier 'vecSend'
                vecSend.erase(start, end);
                ^
wallet/rpcwallet.cpp:1254:13: error: use of undeclared identifier 'vecSend'
            vecSend.emplace(new_weight, CTxOut(amount, CScript() << h_buff << OP_CHECKTEMPLATEVERIFY));
            ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make[2]: *** [wallet/libbitcoin_wallet_a-rpcwallet.o] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all-recursive] Error 1

Fixing the lambda by adding -> leads to one more error:

$ make
Making all in src
  CXX      wallet/libbitcoin_wallet_a-rpcwallet.o
wallet/rpcwallet.cpp:1329:14: error: call to member function 'pushKV' is ambiguous
    metadata.pushKV("radix", radix);
    ~~~~~~~~~^~~~~~
./univalue/include/univalue.h:123:10: note: candidate function
    bool pushKV(const std::string& key, int64_t val_) {
         ^
./univalue/include/univalue.h:127:10: note: candidate function
    bool pushKV(const std::string& key, uint64_t val_) {
         ^
./univalue/include/univalue.h:131:10: note: candidate function
    bool pushKV(const std::string& key, bool val_) {
         ^
./univalue/include/univalue.h:135:10: note: candidate function
    bool pushKV(const std::string& key, int val_) {
         ^
./univalue/include/univalue.h:139:10: note: candidate function
    bool pushKV(const std::string& key, double val_) {
         ^
./univalue/include/univalue.h:114:10: note: candidate function
    bool pushKV(const std::string& key, const UniValue& val);
         ^
./univalue/include/univalue.h:115:10: note: candidate function not viable: no known conversion from 'size_t' (aka 'unsigned long') to 'const std::string' (aka 'const basic_string<char, char_traits<char>, allocator<char> >') for 2nd argument
    bool pushKV(const std::string& key, const std::string& val_) {
         ^
./univalue/include/univalue.h:119:10: note: candidate function not viable: no known conversion from 'size_t' (aka 'unsigned long') to 'const char *' for 2nd argument
    bool pushKV(const std::string& key, const char *val_) {
         ^
1 error generated.
make[2]: *** [wallet/libbitcoin_wallet_a-rpcwallet.o] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all-recursive] Error 1

Adding the cast fixes that one.

With these fixes, I was able to get bitcoind built and running successfully.

Here's my system info for reference:

$ /usr/local/bin/ccache gcc --version
Configured with: --prefix=/Library/Developer/CommandLineTools/usr --with-gxx-include-dir=/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/4.2.1
Apple clang version 11.0.0 (clang-1100.0.33.17)
Target: x86_64-apple-darwin19.3.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

[JeremyRubin]

Thanks! I don't use OSX so didn't notice :) Technically the int could be a uint64_t from a size_t, as to preserve the unsignedness, but your system would crash with a radix that big probably so not to worry