Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround -Wstringop-overflow warnings from fmt #278

Merged
merged 4 commits into from
Sep 19, 2024
Merged

fix: workaround -Wstringop-overflow warnings from fmt #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
906193e
fix: workaround `-Wstringop-overflow` warnings from `fmt`
c-dilks Sep 19, 2024
5d2f62c
fix: handle `clang` too
c-dilks Sep 19, 2024
6951a7a
fix: don't suppress warnings globally
c-dilks Sep 19, 2024
46e924a
fix: increase timeout for example tests
c-dilks Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ foreach example, info : example_sources
[ get_option('test_data_file'), '100' ], # don't run too many events, or meson test log will be huge
),
env: project_test_env,
timeout: 60,
timeout: 120,
)
endif
endif
Expand Down
14 changes: 14 additions & 0 deletions src/iguana/services/Logger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,22 @@
#pragma once

// workaround https://github.com/fmtlib/fmt/issues/4133
#ifdef __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wshift-overflow"
#else
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wstringop-overflow"
#endif
#include <fmt/color.h>
#include <fmt/format.h>
#include <fmt/ranges.h>
#ifdef __clang__
#pragma clang diagnostic pop
#else
#pragma GCC diagnostic pop
#endif

#include <functional>
#include <unordered_map>

Expand Down