Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: workaround -Wstringop-overflow warnings from fmt #278

Merged
merged 4 commits into from
Sep 19, 2024
Merged

fix: workaround -Wstringop-overflow warnings from fmt #278

merged 4 commits into from
Sep 19, 2024

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Sep 19, 2024 •
edited
Loading

Workaround fmtlib/fmt#4133 until fixed (so we can continue to use -Werror on CI here). Revert when fixed.

fixes #277

@c-dilks c-dilks mentioned this pull request Sep 19, 2024
Closed
@c-dilks c-dilks merged commit f27ce57 into main Sep 19, 2024
45 checks passed
@c-dilks c-dilks deleted the workaround-fmt-warnings branch September 19, 2024 20:23
c-dilks added a commit that referenced this pull request Jan 3, 2025
@c-dilks
fix: revert workaround -Wstringop-overflow warnings from fmt
41ec2cf 
`fmt` v11.1 is out.

reverts #278
closes #279
@c-dilks c-dilks mentioned this pull request Jan 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Iguana
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weekly linux-latest pipeline failed on Sunday, September 15th, at 09:05Z
1 participant
@c-dilks