Skip to content

Conversation

andersonmfjr
Copy link

Adds a new property called "alwaysFocusFirstMenuOption" that makes it possible to keep focus on the first item when the list of options is changed. An example can be seen below:

  • Without prop:
    ezgif com-gif-maker

  • With prop:
    ezgif com-gif-maker (1)

@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2021

⚠️ No Changeset found

Latest commit: c960bdf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 20, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c960bdf:

Sandbox Source
react-codesandboxer-example Configuration

andersonmfjr and others added 2 commits July 28, 2021 20:41
It seems logical that this should likely be default behavior so setting default value to true.
@Annie-Huang
Copy link

Is this one similar to the request of #4080?

Is this one going to be merged into master soon?

@stnwk
Copy link

stnwk commented Jul 28, 2022

This PR (open for 1 year) and #4080 (open for 2 years) fix the same thing, that currently cannot be worked around. It would be extremely cool to finally merge this one. The solution is simple and elegant but nobody is merging anything.

Pinging @andrevitalb because I saw recent commit/merge activity from you. Do you think you can help? Thanks! :)

Copy link
Contributor

@andrevitalb andrevitalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality-wise, LGTM

@andrevitalb
Copy link
Contributor

andrevitalb commented Jul 28, 2022

This PR (open for 1 year) and #4080 (open for 2 years) fix the same thing, that currently cannot be worked around. It would be extremely cool to finally merge this one. The solution is simple and elegant but nobody is merging anything.

Pinging @andrevitalb because I saw recent commit/merge activity from you. Do you think you can help? Thanks! :)

@stnwk I'm just able to add reviews, don't have write access, We still need @JedWatson for that.

@stnwk
Copy link

stnwk commented Jul 28, 2022

Oh, thanks for your time and work anyways! Hopefully we can move forward here

@andersonmfjr
Copy link
Author

andersonmfjr commented Aug 19, 2022

@andrevitalb can you review again? any chance of the functionality being merged?
thanks for your time

Copy link
Contributor

@andrevitalb andrevitalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, LGTM

@andrevitalb
Copy link
Contributor

andrevitalb commented Aug 23, 2022

@andrevitalb can you review again? any chance of the functionality being merged? thanks for your time

@andersonmfjr I don't have any write permissions for the repo. We'd have to wait for @JedWatson's approval

@dcousens
Copy link
Collaborator

dcousens commented Oct 31, 2022

@andersonmfjr thanks for the pull request, but I wonder, maybe the more sustainable approach here (for the library and maintainers) is to only support 1 behaviour, and then encourage consumers to control the component themselves if they need something else.

Related

@andersonmfjr
Copy link
Author

@andersonmfjr thanks for the pull request, but I wonder, maybe the more sustainable approach here (for the library and maintainers) is to only support 1 behaviour, and then encourage consumers to control the component themselves if they need something else.

Related

Do you think it is possible to achieve this same behavior with the components control?

In the related PR it only shows that workarounds were done. And apparently they didn't work out so well.

@PratikAwaik
Copy link

@JedWatson can we please merge this, if possible? Lot of people are requesting for this feature and we don't want to do unnecessarily complex workarounds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants