-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feature/always-focus-first-menu-option #4699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feature/always-focus-first-menu-option #4699
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c960bdf:
|
It seems logical that this should likely be default behavior so setting default value to true.
Is this one similar to the request of #4080? Is this one going to be merged into master soon? |
This PR (open for 1 year) and #4080 (open for 2 years) fix the same thing, that currently cannot be worked around. It would be extremely cool to finally merge this one. The solution is simple and elegant but nobody is merging anything. Pinging @andrevitalb because I saw recent commit/merge activity from you. Do you think you can help? Thanks! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality-wise, LGTM
@stnwk I'm just able to add reviews, don't have write access, We still need @JedWatson for that. |
Oh, thanks for your time and work anyways! Hopefully we can move forward here |
Co-authored-by: André Vital <[email protected]>
Co-authored-by: André Vital <[email protected]>
@andrevitalb can you review again? any chance of the functionality being merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, LGTM
@andersonmfjr I don't have any write permissions for the repo. We'd have to wait for @JedWatson's approval |
@andersonmfjr thanks for the pull request, but I wonder, maybe the more sustainable approach here (for the library and maintainers) is to only support 1 behaviour, and then encourage consumers to control the component themselves if they need something else. Related |
Do you think it is possible to achieve this same behavior with the components control? In the related PR it only shows that workarounds were done. And apparently they didn't work out so well. |
@JedWatson can we please merge this, if possible? Lot of people are requesting for this feature and we don't want to do unnecessarily complex workarounds |
Adds a new property called "alwaysFocusFirstMenuOption" that makes it possible to keep focus on the first item when the list of options is changed. An example can be seen below:
Without prop:

With prop:
