Start work on hacky Xbox port #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayFoxRox
force-pushed
the
hacky-xbox
branch
2 times, most recently
from
6f8e1f0 to
b4f86a4
Compare
JayFoxRox
force-pushed
the
hacky-xbox
branch
2 times, most recently
from
b15d6c4 to
8d38c86
Compare
JayFoxRox
force-pushed
the
hacky-xbox
branch
2 times, most recently
from
d6b7e70 to
f4c47c5
Compare
JayFoxRox
commented
May 21, 2019
JayFoxRox
commented
May 21, 2019
JayFoxRox
commented
May 21, 2019
|
|
||
| #ifdef XBOX | ||
| __attribute__((constructor(101))) static void reserve_memory() { | ||
| // Reserve the space for the EXE |
There was a problem hiding this comment.
- Free LaunchDataPage?
- Move saved AV data address?
- Move framebuffer elsewhere?
JayFoxRox
commented
May 21, 2019
| #ifdef XBOX | ||
| __attribute__((constructor(102))) static void start_log() { | ||
| // Clear log | ||
| FILE* f = freopen("log.txt", "wb", stdout); |
There was a problem hiding this comment.
Write this to some disk folder, so we can run from DVD
JayFoxRox
force-pushed
the
hacky-xbox
branch
2 times, most recently
from
301757c to
8a2354a
Compare
JayFoxRox
commented
Jun 5, 2019
JayFoxRox
commented
Jun 6, 2019
main.c
Outdated
| uint32_t* vtable = (uint32_t*)Memory(vtableAddress); | ||
| for(unsigned int i = 0; i < slotCount; i++) { | ||
| // Point addresses to themself | ||
| char* slotName = malloc(128); | ||
| char* slotName = &slotNames[i * 64]; |
There was a problem hiding this comment.
This seems like a stupid change; just calculate real length and stick to malloc
JayFoxRox
force-pushed
the
hacky-xbox
branch
8 times, most recently
from
3d135f7 to
7efaa1d
Compare
JayFoxRox
commented
Jun 6, 2019
JayFoxRox
force-pushed
the
hacky-xbox
branch
2 times, most recently
from
24a579a to
ff56e2a
Compare
JayFoxRox
commented
Jun 8, 2019
| Address code_address = buffer; | ||
| buffer += code_size; | ||
| buffer_size -= code_size; | ||
| #endif |
There was a problem hiding this comment.
Should be moved into the allocator itself, so other code can also benefit (for small allocations).
It isn't necessary if the allocator has smaller pages.
JayFoxRox
commented
Jun 12, 2019
emulation.c
Outdated
| @@ -655,7 +655,7 @@ unsigned int CreateEmulatedThread(uint32_t eip) { | |||
| stack = MapMemory(stackAddress, stackSize, true, true, false); | |||
| } | |||
| static int threadId = 0; | |||
| uint32_t esp = stackAddress + stackSize / 2 + 256 * 1024 * threadId++; // 256 kiB per late thread | |||
| uint32_t esp = stackAddress + stackSize; | |||
There was a problem hiding this comment.
Needs to assert that threadId == 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically nothing yet, I was just curious how much work this might be.
I currently don't have any intentions of finishing this.
Requires JayFoxRox/nxdk#8 for compilation.Based on #45
TODO:
Make uc_native functionalMove host memory allocation intoMapMemory(needs full control over memory layout)Implement uc_nativeAllocate, but align users which require itAvoid relocation of exe sections, or avoid referring to them (as(fixed upstream using strup; not ideal.. but okay)export->namecurrently does this), so they can be unloaded