Assert on the queue name, not the endpoint name, and untag Bug_2307 (GH-3827) - #3830
Merged
Merged
Conversation
…H-3827) This was never a product bug. The 2026-08-02 triage was right that the listener IS created for the batch element type -- so GH-2307 works -- but concluded the endpoint had been given "the raw type name rather than the sanitized queue name". Dumping the endpoints shows both names are exactly what they should be: EndpointName='Wolverine.AzureServiceBus.Tests.Bugs.BatchedItem' Uri='asb://queue/wolverine.azureservicebus.tests.bugs.batcheditem' The Azure Service Bus entity -- the thing conventional routing is responsible for -- is correctly sanitized. EndpointName is a LOGICAL name and deliberately is not the entity name: MessageRoutingConvention has `endpoint.EndpointName = queueName` commented out on both listener-creation paths, and the transport's own system endpoints do the same (AzureServiceBusResponses -> asb://queue/wolverine.response.*). AzureServiceBusQueue.QueueName is the physical name, assigned once at construction; EndpointName is mutable and takes the friendly value afterwards. So the test was reading the wrong property. It now asserts on QueueName, which is what GH-2307 is actually about, and the Category=Flaky tag comes off -- returning the class to CIAzureServiceBus. Passes 3/3 in ~5s against the emulator. Full wolverine.slnx Release build clean. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WHAuhdWS3XeAk16swV9G8m
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3827.
This was never a product bug, contrary to how I filed the issue — I inherited the diagnosis from the in-file note instead of reproducing it first. Correction is on the issue too.
Bug_2307_batching_with_conventional_routingcarried[Trait("Category", "Flaky")], excluding it fromCIAzureServiceBus. The note said the listener's "EndpointName is just the raw type name rather than the sanitized queue name — a naming bug in the GH-2307 fix".Dumping every Azure Service Bus endpoint the convention builds says otherwise:
The listener exists and its Azure Service Bus entity name is correct. GH-2307 works end to end; nothing is misnamed on the broker.
EndpointNameis a logical label that deliberately is not the entity name:MessageRoutingConventionhasendpoint.EndpointName = queueNamecommented out on both listener-creation paths.AzureServiceBusResponses→asb://queue/wolverine.response.*,AzureServiceBusRetries→asb://queue/wolverine.retries.*.AzureServiceBusQueue.QueueNameis the physical entity name, assigned once at construction;EndpointNameis mutable and picks up the friendly value afterwards.So the test was asserting on the wrong property. It now asserts on
QueueName— the thing GH-2307 is actually about — and theFlakytag comes off.Verification
wolverine.slnxRelease build clean, 0 warningsThe class returns to
CIAzureServiceBus.🤖 Generated with Claude Code
https://claude.ai/code/session_01WHAuhdWS3XeAk16swV9G8m