Azure Service Bus batching with conventional routing: listener EndpointName is the raw type name, not the sanitized queue name

[jeremydmiller]

The in-file note on this class says "Needs its own issue"; that was never actioned.

Bug_2307_batching_with_conventional_routing is tagged [Trait("Category", "Flaky")], removing 1 test from CI. It is not flaky — it fails 1 of 1, deterministically, and since the entity-name sanitizing fix it fails in 5 seconds on a plain assertion rather than a 2-minute broker timeout, which makes the real defect readable:

Expected a listener endpoint for queue 'wolverine.azureservicebus.tests.bugs.batcheditem'
but found only: Wolverine.AzureServiceBus.Tests.Bugs.BatchedItem, AzureServiceBusResponses, ...

The listener is created for the batch element type — that much of #2307 works. Its EndpointName is just the raw type name (Wolverine.AzureServiceBus.Tests.Bugs.BatchedItem) rather than the sanitized queue name (wolverine.azureservicebus.tests.bugs.batcheditem).

So this is a naming bug in the #2307 fix, not a routing or provisioning failure: batching with conventional routing does not run the element type's endpoint name through the same sanitizing that the queue name gets.

Fixing it should let the tag come off and return the test to CIAzureServiceBus.

[jeremydmiller]

Correction — I filed this as a product bug and it is not one. Reproduced it, and the diagnosis in the issue body (inherited from the in-file note) is wrong.

Dumping every Azure Service Bus endpoint the convention builds:

EndpointName='Wolverine.AzureServiceBus.Tests.Bugs.BatchedItem'
Uri='asb://queue/wolverine.azureservicebus.tests.bugs.batcheditem'   <- the real queue, correctly sanitized
IsListener=True

The listener exists and its Azure Service Bus entity name is correctly sanitized. GH-2307's behaviour works end to end. Nothing is misnamed on the broker.

What is actually happening is that the test asserted on the wrong property. EndpointName is a logical label and is deliberately not the entity name:

• MessageRoutingConvention has endpoint.EndpointName = queueName commented out on both listener-creation paths.
• The transport's own system endpoints behave the same way — AzureServiceBusResponses → asb://queue/wolverine.response.*, AzureServiceBusRetries → asb://queue/wolverine.retries.*.
• AzureServiceBusQueue.QueueName is the physical entity name, assigned once at construction; EndpointName is mutable and picks up the friendly value afterwards.

So the fix is in the test: assert on QueueName, which is the thing GH-2307 is actually about, rather than EndpointName. With that change it passes 3/3 in ~5s, and the [Trait("Category", "Flaky")] tag comes off the class, returning it to CIAzureServiceBus.

Worth noting for the other two tags I filed alongside this one (#3825, #3826): those diagnoses are also inherited from in-file notes and have not yet been independently reproduced. I'll verify each against the emulator before proposing any fix rather than trusting the note, which is exactly what this one turned out to need.