Skip to content

Fix missing bracket in LogStartingActivity log message #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydmiller merged 1 commit into from
Apr 12, 2026
Merged

Fix missing bracket in LogStartingActivity log message #2498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Testing/CoreTests/Configuration/auditing_determination.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public void use_audit_member_named_id_and_disambiguate()



chain.SourceCode!.ShouldContain("\"Starting to process CoreTests.Configuration.AuditedMessage2 ({EnvelopeId} with Id: {Id}, AccountIdentifier: {AccountId}\"");
chain.SourceCode!.ShouldContain("\"Starting to process CoreTests.Configuration.AuditedMessage2 ({EnvelopeId}) with Id: {Id}, AccountIdentifier: {AccountId}\"");

/*
((Microsoft.Extensions.Logging.ILogger)_loggerForMessage).Log(Microsoft.Extensions.Logging.LogLevel.Information, "Starting to process CoreTests.Configuration.AuditedMessage2 ({EnvelopeId} with Id: {Id}, AccountIdentifier: {AccountId}", context.Envelope.Id, auditedMessage2.Id, auditedMessage2.AccountId);
Expand Down
2 changes: 1 addition & 1 deletion src/Wolverine/Logging/LogStartingActivity.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public override IEnumerable<Variable> FindVariables(IMethodVariables chain)
public override void GenerateCode(GeneratedMethod method, ISourceWriter writer)
{
writer.WriteComment("Application specific auditing");
var template = _members.Any(x => x.Member.Name.EqualsIgnoreCase("id")) ? $"Starting to process {_inputType.FullNameInCode()} ({{EnvelopeId}}" : $"Starting to process {_inputType.FullNameInCode()} ({{Id}})" ;
var template = _members.Any(x => x.Member.Name.EqualsIgnoreCase("id")) ? $"Starting to process {_inputType.FullNameInCode()} ({{EnvelopeId}})" : $"Starting to process {_inputType.FullNameInCode()} ({{Id}})" ;
if (_members.Count != 0)
{
template += " with " + _members.Select(m => $"{m.MemberName}: {{{m.Member.Name}}}").Join(", ");
Expand Down
Loading