Fix missing bracket in LogStartingActivity log message#2498
Merged
jeremydmiller merged 1 commit intomainfrom Apr 12, 2026
Merged
Fix missing bracket in LogStartingActivity log message#2498jeremydmiller merged 1 commit intomainfrom
jeremydmiller merged 1 commit intomainfrom
Conversation
The log template for messages with an "Id" member was missing the
closing parenthesis after {EnvelopeId}, producing malformed log output.
Also updates the corresponding test assertion to match the corrected
output.
Original fix by @lyall-sc in #2496.
Co-Authored-By: lyall-sc <182926846+lyall-sc@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
)in the log template for messages with anIdmember — was producing({EnvelopeId} with ...instead of({EnvelopeId}) with ...auditing_determination.use_audit_member_named_id_and_disambiguateto match the corrected outputBased on @lyall-sc's fix in #2496, with the addition of the test update needed to pass CoreTests.
Test plan
dotnet test src/Testing/CoreTests/ --framework net9.0— all 1289 tests passCloses #2496
🤖 Generated with Claude Code