Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ private async Task moveToErrorQueueAsync(RabbitMqEnvelope envelope, Cancellation
{
if (envelope.RabbitMqListener.Channel is not null)
{
// For idempotency
// Mark as acknowledged before the NACK so that any subsequent
// CompleteAsync() call is a no-op (prevents double ack/nack)
envelope.Acknowledged = true;
envelope.HasBeenAcked = true;
await envelope.RabbitMqListener.Channel.BasicNackAsync(envelope.DeliveryTag, false, false, token);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,12 @@ internal void OverrideDeliveryTag(ulong tag)
internal RabbitMqListener RabbitMqListener { get; }
internal ulong DeliveryTag { get; private set;}

public bool Acknowledged { get; private set; }
public bool Acknowledged { get; internal set; }

internal async Task CompleteAsync()
{
if (Acknowledged) return;

await RabbitMqListener.CompleteAsync(DeliveryTag);
Acknowledged = true;
}
Expand Down
Loading