Fix RabbitMQ double acknowledgement on InvokeAsync deserialization exceptions#2234
Merged
jeremydmiller merged 1 commit intomainfrom Feb 24, 2026
Merged
Fix RabbitMQ double acknowledgement on InvokeAsync deserialization exceptions#2234jeremydmiller merged 1 commit intomainfrom
jeremydmiller merged 1 commit intomainfrom
Conversation
MoveToErrorQueue.ExecuteAsync() calls both MoveToDeadLetterQueueAsync() (which NACKs the message) and CompleteAsync() (which ACKs it). The second ack on an already-consumed delivery tag causes RabbitMQ to close the channel with PRECONDITION_FAILED, breaking all subsequent InvokeAsync() calls. Fix: Make RabbitMqEnvelope.CompleteAsync() idempotent by checking the Acknowledged flag before calling BasicAckAsync, and set Acknowledged=true before the NACK in moveToErrorQueueAsync so the subsequent CompleteAsync is a no-op. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RabbitMqEnvelope.CompleteAsync()idempotent so a second call is a no-opAcknowledged = truebefore the NACK inmoveToErrorQueueAsyncso the subsequentCompleteAsync()fromMoveToErrorQueue.ExecuteAsync()is skippedRoot Cause
MoveToErrorQueue.ExecuteAsync()calls bothMoveToDeadLetterQueueAsync()(which NACKs the message) andCompleteAsync()(which ACKs it). The second ack/nack on an already-consumed delivery tag causes RabbitMQ to close the channel withPRECONDITION_FAILED - unknown delivery tag, which deletes the response queue and breaks all subsequentInvokeAsync()calls.Test plan
Wolverine.RabbitMQbuilds clean🤖 Generated with Claude Code