Skip to content

Add index on column doc_type, see #765 - #766

Merged
jeremydmiller merged 2 commits into
JasperFx:masterfrom
mdissel:HiearchyDocumentTypeIndex
May 23, 2017
Merged

jeremydmiller merged 2 commits into
JasperFx:masterfrom
mdissel:HiearchyDocumentTypeIndex

Conversation

@mdissel

@mdissel mdissel commented May 22, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@jeremydmiller

Copy link
Copy Markdown
Member

Hey, could you throw a unit test on DocumentTable for "not hierarchical, no index" and "hierarchical, so index"? Otherwise that looks good to me

@mdissel

mdissel commented May 22, 2017

Copy link
Copy Markdown
Contributor Author

But if there's no hiearchy the column docType is not created..

@jeremydmiller

Copy link
Copy Markdown
Member

@mdissel I just meant the negative case is all. I'm good with this and pulling it now.

Thanks for taking this on.

@jeremydmiller
jeremydmiller merged commit cf90b85 into JasperFx:master May 23, 2017
@jeremydmiller

Copy link
Copy Markdown
Member

@mdissel Couple issues with this one that I'm taking care of:

  • There was already a separate facility to index the Deleted column, so I just removed the code in DeletedColumn
  • The unit test wasn't written correctly and failed. Easy fix though.

@mdissel

mdissel commented May 23, 2017

Copy link
Copy Markdown
Contributor Author

Thanks.. i will run all the tests next time.. sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants