Repository navigation
Weasel 9.48.0 - #5802
Merged
Merged
Weasel 9.48.0#5802
Conversation
Three of the six issues in this Weasel release are SQL Server only and inert here. What reaches Marten is the PostgreSQL parameter-type work and one PostgreSQL partitioning fix. weasel#758/#759 is the headline: a private helper in five providers ended in `?? <catch-all>`, which can never return null, so every fall-through branch after the first was dead code. PostgreSQL was one of the two providers that already fell through correctly, so the resolution behaviour Marten sees is unchanged. The part that was a hard failure rather than a slow query: both AddParameters overloads resolved through ToParameterType on the TYPE, going around the value-aware seam weasel#403 added for Npgsql, so a UTC DateTime in a parameter bag was bound as `timestamp without time zone` and Npgsql threw outright, while the same value through AddNamedParameter worked. weasel#764 fixes PostgreSQL's numeric arm in PartitionExtensions.FormatSqlValue, which rendered with the current culture: a decimal partition bound carried a comma separator under de-DE and a negative one a U+2212 minus sign under sv-SE, fi-FI, lt-LT or nb-NO. The date arms were already invariant, which is what made the numeric one read as deliberate. No Marten code changes. Restores and builds clean against the published packages; the JasperFx 2.98.0 floor Weasel.Core now declares was already satisfied by #5801. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weasel 9.48.0, published today. Release notes: https://weasel.jasperfx.net/release-9-48
Nine PRs went into it: the parameter-type catch-all fix (weasel#758/#759 → #760) and the three issues it uncovered (#761, #762, #763), three SQL Server bugs found from Polecat (#764, #765, #766), MySqlConnector 2.6.1 for GHSA-473q-m89c-ghf8 (#767) and JasperFx 2.98.0 (#769).
Two behaviour changes upstream, neither of which this repo trips:
ToParameterTypethrows for one where it returned a character catch-all; and aDateTimeparameter binds asDateTime2rather than a date-only type that dropped the time of day. The generated column type is unchanged, so no schema diff.EnumStorage, with new overloads taking one. Affects anAsStringconsumer on MySQL or Oracle only.What reaches Marten
Three of the six issues are SQL Server only and inert here.
AddParametersoverloads resolved throughToParameterTypeon the type, going around the value-aware seam weasel#403 added for Npgsql, so a UTCDateTimein a parameter bag was bound astimestamp without time zoneand Npgsql threw outright, while the same value throughAddNamedParameterworked.PartitionExtensions.FormatSqlValuerendered with the current culture: a decimal partition bound carried a comma separator underde-DE, and a negative one a U+2212 minus sign undersv-SE,fi-FI,lt-LTornb-NO. The date arms were already invariant with a comment saying why, which is exactly what made the numeric one read as deliberate. Marten's tenant and list partitions are string bounds, so this bites a numeric partition bound only.Integerfor an int-backed enum. One difference: an enum now resolves through its underlying type, so along-backed enum givesBigintrather than silently narrowing toInteger.I checked the call sites rather than assuming:
RuntimeCompiledQueryDescriptorFactoryandPostgresStorageDialectcallToParameterTypeand both pass types Npgsql maps;StoreOptions.IdentityandExecuteSqlStorageOperationuseTryGetDbType, which still returns null for an unmapped type.Verification
No Marten code changes.
dotnet restoreanddotnet build src/Marten.slnxclean against the published packages (not a local pack), 0 errors. The JasperFx 2.98.0 floorWeasel.Corenow declares was already satisfied by #5801.🤖 Generated with Claude Code