Compliance wave 8: enroll conjoined event tenancy and subscriptions - #5205
Merged
Conversation
Adopts JasperFx 2.45.0 and enrolls the last two suites in the event sourcing compliance backlog. The library goes to 28 suites / 230 tests, both stores, still zero capability gates -- and with these two the backlog is empty. ConjoinedEventTenancyCompliance (#5148) turned out to need no tenant-scoped session seam after all. OpenSession(IEventDatabase, tenantId) is already on the shared generic IEventStore<,>, and TenancyStyle is already a shared JasperFx.MultiTenancy enum, so the only addition is the ComplianceStoreConfig.ConjoinedEventTenancy switch that MartenComplianceFixture maps onto Events.TenancyStyle. SubscriptionCompliance (#5151) is the one suite an empty subclass cannot close on its own. Both products declare ISubscription with an identical member, but ProcessEventsAsync returns a per-product IChangeListener, so the shared ComplianceSubscription is a partial class and each consumer completes it. The Marten half lives in Marten.Testing beside MartenComplianceFixture rather than in EventSourcingTests, because both assemblies reference the source-only compliance package and therefore both compile the library's half of the partial. Verified against the published 2.45.0 package, not the ComplianceSourceDir dev loop: 230/230 compliance, zero skips, and all 28 library suites confirmed enrolled by diffing the package's suite files against the subclass declarations -- a bump satisfying a new registrar member is not by itself evidence a suite runs, which is how StrongTypedIdentityCompliance shipped unrun in wave 6. Full EventSourcingTests 1796/0/7 on net9.0. Closes #5148 Closes #5151 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RrQZYcL13PEek7FErj9PGx
19 tasks
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts JasperFx 2.45.0 (jasperfx#642) and enrolls the last two suites in the event sourcing compliance backlog. The shared library goes to 28 suites / 230 tests, both stores, still zero capability gates — and with these two, the ES backlog filed under #5118 is empty.
The two suites
ConjoinedEventTenancyCompliance(#5148) — the issue priced this as needing a tenant-scoped session seam. It didn't.OpenSession(IEventDatabase, tenantId)is already on the shared genericIEventStore<,>, andTenancyStyleis already a sharedJasperFx.MultiTenancyenum. The only seam addition is theComplianceStoreConfig.ConjoinedEventTenancyswitch, whichMartenComplianceFixturemaps ontoEvents.TenancyStyle.SubscriptionCompliance(#5151) — the one suite an empty subclass cannot close by itself. Both products declareISubscriptionwith an identical member, butProcessEventsAsyncreturns a per-productIChangeListener, so that signature cannot be written once upstream. The sharedComplianceSubscriptionis therefore apartial classthat each consumer completes; Marten's half isComplianceSubscription.Marten.cs.That file lives in
Marten.TestingbesideMartenComplianceFixturerather than inEventSourcingTestson purpose: both assemblies reference the source-only compliance package, so both compile the library's half of the partial, and both need the completing half to satisfy it.Verification
Run against the published 2.45.0 package, not the
-p:ComplianceSourceDir=dev loop.StrongTypedIdentityComplianceshipped 11 tests unrun in wave 6 (Enrol StrongTypedIdentityCompliance (#5144) #5198).EventSourcingTests: 1796 passed / 0 failed / 7 skipped on net9.0 — the 7 skips are the pre-existing baseline, unchanged.Notes for the reviewer
Closes #5148
Closes #5151
🤖 Generated with Claude Code
https://claude.ai/code/session_01RrQZYcL13PEek7FErj9PGx