Enrol StrongTypedIdentityCompliance (#5144) - #5198
Merged
Merged
Conversation
The suite shipped in JasperFx 2.42.0 (#636) and arrived in this repo with the 2.42.2 bump in #5197, which also added the RegisterValueType<T>() registrar member it needs -- that member is on IComplianceStoreRegistrar, so MartenComplianceFixture had to implement it to compile. The subclass closing the suite over Marten's session pair was never added, so the 11 tests have been shipping unrun on this store. No seam change and no package bump: 11/11 green on net9.0 as-is. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VpDCvJcBDZerieJB4JEHde
Member
Author
|
Full Polecat's side is now verified too — its 2.42.2 catch-up runs the same 178 compliance tests across 22 suites, zero gates, exact parity with this store. PR to follow in that repo. |
29 tasks
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
StrongTypedIdentityCompliancesuite shipped in JasperFx 2.42.0 (#636). It arrived in this repo with the 2.42.2 bump in #5197 — which also added theRegisterValueType<T>()registrar member the suite needs, because that member sits onIComplianceStoreRegistrarandMartenComplianceFixturehad to implement it to compile at all.The subclass closing the suite over Marten's session pair was never added, so these 11 tests have been shipping unrun on this store. This PR is the missing three lines.
What it covers
11 tests across {Guid-backed, string-backed} × {live, inline, async} × {
AggregateStream,FetchForWriting,FetchForExclusiveWriting,FetchLatest} — deliberately broad, because strong-typed id failures cluster at the edges and a suite proving one path proves very little. That breadth is exactly what found the bug fixed in #5193:determineFetchPlansent any non-Guid/stringTIddown the natural-key branch and stored anullidentity strategy.Cost
Nothing. No package bump (already on 2.42.2), no seam change, no alias, no fixture member. Additive file only, in its own schema (
compliance_strong_typed/compliance_strong_typed_string).Verification
strong_typed_identity_compliance11 passed / 0 failed on net9.0. FullEventSourcingTestsrun attached below once complete.Marten now runs 178 shared compliance tests across 22 suites, no capability gates.
Polecat's enrolment follows in its 2.42.2 catch-up — it is currently on 2.39.4 and a full wave behind.
Closes #5144
🤖 Generated with Claude Code
https://claude.ai/code/session_01VpDCvJcBDZerieJB4JEHde