Replace Model Shader with PBR Shader from gdx-gltf #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesTKhan
changed the title
# Conflicts: # commons/src/main/com/mbrlabs/mundus/commons/shaders/ModelShader.java # commons/src/main/com/mbrlabs/mundus/commons/shaders/model.vert.glsl # commons/src/main/com/mbrlabs/mundus/commons/shaders/shadowmap.frag.glsl # editor/src/main/com/mbrlabs/mundus/editor/ui/modules/dialogs/DirectionalLightsDialog.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the Mundus model shader with the PBR shader by extending gdx-gltf's shader classes. Another new feature is the auto-importing of model textures and materials when importing a model. The materials are read from on import and then assigned to the models corresponding material assets.
This adds support for animations, and all the other benefits of the PBR shaders. This is still a work in progress as its quite a bit of work and issues to take into account.
Investigate IBL and Mundus SkyboxPushed out for later release due to scope creep[BREAKING CHANGE] Synchronize fog between Mundus and PBR Shaders - Fog now has new parameters and more closely aligns with libGDX and PBR shaders. You may need to adjust fog.
[BREAKING CHANGE] The loadScene method for the runtime has changed. A ModelBatch is no longer required to be passed in.
Bone counts of model assets are now tracked, no more crashes for bone counts