Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated libgdx to 1.11.0 #60

Merged
merged 4 commits into from
Apr 25, 2023
Merged

Updated libgdx to 1.11.0 #60

merged 4 commits into from
Apr 25, 2023

Conversation

Dgzt
Copy link
Collaborator

@Dgzt Dgzt commented Jun 7, 2022

No description provided.

@Dgzt Dgzt marked this pull request as ready for review June 12, 2022 08:01
@JamesTKhan
Copy link
Owner

JamesTKhan commented Jun 15, 2022

I have not merged yet as I am noticing some subtle micro-stutters on the demo app when running on this branch. Primarily in the "Second Scene". The FPS still shows 60fps but some stuttering is visible in the 3d world. I might have to experiment with it more after the upcoming game jam, there is no telling what the cause is.

I might have to look at all the change log for 1.11.0 to see if any thing stands out

# Conflicts:
#	editor/CHANGES
@Dgzt
Copy link
Collaborator Author

Dgzt commented Aug 2, 2022

I've updated this branch with the latest master branch. Could you check there are still some stuttering in the demo app?

@JamesTKhan
Copy link
Owner

@Dgzt Unfortunately I still see the micro-stuttering. The game stays at 60fps but I get jarring microstutters when moving the camera around on the example project. On master branch, its smooth. I made a short video to show what I am seeing. I am thinking it might be lwjgl or window related but I will have to dig into it more

2022-08-17.15-35-19_Trim.mp4

@JamesTKhan
Copy link
Owner

Confirmed this is not a Mundus issue. Replicated same issue in a barebones test project. It seems to only happen on Windowed mode on 1.11.0. Raised the issue in discord but will update here when I know more.

@JamesTKhan
Copy link
Owner

JamesTKhan commented Aug 18, 2022

After some talks in Discord, I tested on 1.10.0, and overrode the LWJGL version to 3.3.0 (1.10.0 uses 3.2.3) and replicated the stuttering so it seems to be a LWJGL (or GLFW) issue because LWJGL version was updated on 1.11.0. It only appears to happen in windowed mode.

So I am not sure when we can merge this PR.

https://discord.com/channels/348229412858101762/873537733430226964/1009676857605628017

@Dgzt
Copy link
Collaborator Author

Dgzt commented Aug 18, 2022

I see, I hope the lwjgl or glfw team will fix it soon.

@Dgzt
Copy link
Collaborator Author

Dgzt commented Apr 20, 2023

There was new lwjgl version (3.3.2) with updated glfw:. I hope this will resolve micro-stuttering issue.

@JamesTKhan
Copy link
Owner

We can hope. I looked through the change lists for 3.3.2 and don't see it mentioned but who knows. Have you noticed the micro stuttering on your end at all? It is terrible for me on libGDX 1.11 when windowed mode.

@Dgzt
Copy link
Collaborator Author

Dgzt commented Apr 20, 2023

We can hope. I looked through the change lists for 3.3.2 and don't see it mentioned but who knows. Have you noticed the micro stuttering on your end at all? It is terrible for me on libGDX 1.11 when windowed mode.

No, I haven't. My eyes are not enough good or maybe it depends on OS and/or GPU type.

@JamesTKhan
Copy link
Owner

JamesTKhan commented Apr 24, 2023

I will likely end up merging this soon. We can't stay on 1.10 forever and no matter what I cannot seem to pinpoint the stuttering or find any mention of it on GLFW or LWJGL3 GitHub. Maybe this is just an issue on my end, difficult to say.

@Dgzt
Copy link
Collaborator Author

Dgzt commented Apr 25, 2023

The 3.3.2 update has merged into libGDX. Could you try with the latest libGDX snapshot?

@JamesTKhan
Copy link
Owner

The 3.3.2 update has merged into libGDX. Could you try with the latest libGDX snapshot?

The stuttering appears to be gone on 1.11.1-SNAPSHOT!

Copy link
Owner

@JamesTKhan JamesTKhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't even replicate the stuttering this morning on 1.11.0 or 1.11.1-Snapshot...
Not sure what is happening but we can merge this now.

@JamesTKhan JamesTKhan merged commit de5c308 into master Apr 25, 2023
@JamesTKhan JamesTKhan deleted the libgdx-1.11.0 branch April 25, 2023 13:20
@Dgzt
Copy link
Collaborator Author

Dgzt commented Apr 25, 2023

Strange. As I remember RafaSKB also had this suttering on his environment, not only your environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants