Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max height for heightmap #182

Merged
merged 6 commits into from
Jun 14, 2023
Merged

Max height for heightmap #182

merged 6 commits into from
Jun 14, 2023

Conversation

antzGames
Copy link
Collaborator

Added a minMax field to HeightMapTab.kt

If left blank, or set to zero (which would generate a flat terrain) then a default value positive 100 is set.
If user sets the minMax value to negative then the heightmap is inverted.

I think the Terraformer class does not allow negative minHeight so that is why I only implemented one min/max field.

See #174 (comment) for more info and screenshots.

@antzGames antzGames requested review from Dgzt and JamesTKhan May 29, 2023 14:57
@Dgzt
Copy link
Collaborator

Dgzt commented May 31, 2023

Looks good. I think a tooltip with some information would be useful like in settings. What do you think?

Edit: The text and input field are one class, maybe not easy implement into the tooltip. If not easy then just keep this comment.

@JamesTKhan
Copy link
Owner

I agree a tooltip would be preferred if feasible, to explain the behavior like when the value is negative.

@antzGames
Copy link
Collaborator Author

Ok I added more detailed information:

image

So I removed negative values. If the user enters a negative value, then I make that value positive. Empty or zero values defaults to 100.

Let me know if you have any more suggestions.

@antzGames antzGames changed the title Min.max heightmap field Max height for heightmap Jun 8, 2023
@JamesTKhan
Copy link
Owner

Looks good on my end, thank you!

@JamesTKhan JamesTKhan merged commit f96f2db into JamesTKhan:master Jun 14, 2023
@antzGames antzGames deleted the min.max-heightmap branch June 14, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants