Max height for heightmap #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dgzt
approved these changes
May 31, 2023
|
Looks good. I think a tooltip with some information would be useful like in settings. What do you think? Edit: The text and input field are one class, maybe not easy implement into the tooltip. If not easy then just keep this comment. |
|
I agree a tooltip would be preferred if feasible, to explain the behavior like when the value is negative. |
|
Ok I added more detailed information:
So I removed negative values. If the user enters a negative value, then I make that value positive. Empty or zero values defaults to 100. Let me know if you have any more suggestions. |
|
Looks good on my end, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
minMaxfield toHeightMapTab.ktIf left blank, or set to zero (which would generate a flat terrain) then a default value positive 100 is set.
If user sets the minMax value to negative then the heightmap is inverted.
I think the
Terraformerclass does not allow negativeminHeightso that is why I only implemented one min/max field.See #174 (comment) for more info and screenshots.