Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min/Max fields for HeightMap terrain generation #174

Closed
JamesTKhan opened this issue May 10, 2023 Discussed in #169 · 2 comments
Closed

Min/Max fields for HeightMap terrain generation #174

JamesTKhan opened this issue May 10, 2023 Discussed in #169 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@JamesTKhan
Copy link
Owner

JamesTKhan commented May 10, 2023

Unlike the Perlin Noise generator, there is no way to input custom min/max height values when loading a height map onto a terrain. We should look into adding min/max fields on the HeightMap tab. The height map generator code already supports a max value field and uses an hard coded value (see discussion), but may need extending to add min height.

Perlin with min/max
image

No min/max
image

Discussed in #169

@JamesTKhan JamesTKhan added enhancement New feature or request good first issue Good for newcomers labels May 10, 2023
@antzGames antzGames self-assigned this May 29, 2023
@antzGames
Copy link
Collaborator

Terraformer.heightMap(terrainComponent).minHeight() looks like cannot be negative and it seems that the minimum is always 0.

Therefore, I have implemented a Min/Max field. If positive then the terrain generates from 0 to max value. If negative, then it inverts the height map. I think of this as a feature. If min/max value set is blank or is zero, it automatically defaults to +100.

image

image

@JamesTKhan
Copy link
Owner Author

Resolved by #182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants