Closed
Conversation
This was referenced Nov 16, 2017
Owner
|
Thanks for the contribution. Meanwhile, can you please branch and develop the subsequent fixes for PR? I'm always a bit hesitated to merge PRs with massive files involved, and in this case it is the base for the rest ones. What do you think? |
Contributor
Author
|
I understand the sense of hesitation. However, the changes are just formatting, mostly. A careful review may be feel safer. |
Contributor
Author
|
I will separate the two later prs from this one. |
Contributor
Author
|
the latter two prs have been decoupled from this one, and this pr is also no longer depend on the previous one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No essential change except removes all annoying warns by tslint, happy coding!