Jump to location of current file when click view pdf button#311
Closed
innerlee wants to merge 1 commit intoJames-Yu:masterfrom
Closed
Jump to location of current file when click view pdf button#311innerlee wants to merge 1 commit intoJames-Yu:masterfrom
innerlee wants to merge 1 commit intoJames-Yu:masterfrom
Conversation
Contributor
Author
|
I used this functionality these days, it goes generally good. So this pr can hold on, serves an issue, and wait for a better implementation. |
Contributor
Author
|
Thoughts on new implementation: relocate the page only if the current cursor position is not visible. |
Contributor
Author
|
I do not have time to implement a good version of this (may be one can ref https://github.com/izuzak/atom-pdf-view/blob/7922066915be352540e1d5eb0ac9542dd244325e/lib/pdf-editor-view.js#L224), and the current implemenation is ugly. So, it does not have meaning to keep it open :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is good to let this configurable. However, make this behavior default is good in the short run.