Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KeybaordUtil/KPSwitchRootLayoutHandler):add detach mathod and ada… #33

Merged
merged 1 commit into from
Jul 28, 2016
Merged

Conversation

sollian
Copy link

@sollian sollian commented Jul 12, 2016

这次的可以么,麻烦看下

@@ -97,6 +98,9 @@ public void handleBeforeMeasure(final int width, int height) {
}

// 检测到真正的 由于键盘收起触发了本次的布局变化
if (Math.abs(offset) < KeyboardUtil.getMinKeyboardHeight(mTargetRootView.getContext())) {
return;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里加一个warn的Log

@Jacksgong
Copy link
Owner

👍 再修改下这两个。

@sollian
Copy link
Author

sollian commented Jul 26, 2016

你好,这个可以合入了么?还是已经合入了?还需要我操作什么吗

@Jacksgong
Copy link
Owner

@sollian 在commit message 尾部加上 Closes #34

@Jacksgong
Copy link
Owner

因为这个commit 应该是修复了这个Issue了: #34

@Jacksgong
Copy link
Owner

我直接merge回去,然后我这边处理吧。

@Jacksgong
Copy link
Owner

Published since v1.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants