lishouxian first pull request #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| new KeyboardStatusListener(isFullScreen, isTranslucentStatus, | ||
| isFitSystemWindows, | ||
| contentView, target, listener)); | ||
| ViewTreeObserver.OnGlobalLayoutListener l = new KeyboardStatusListener( |
There was a problem hiding this comment.
这里的命名改下: l -> globalLayoutListener
|
感谢你的PR，很nice的修改，不过需要做以下规范的调整:
任何问题，保持交流，如果始终存在疑惑，交流起来麻烦直接来这里交流: https://gitter.im/Jacksgong/JKeyboardPanelSwitch |
|
HI, 我看到你提交了修改，不过commit message并不规范。需要通过 任何问题，保持交流，如果始终存在疑惑，交流起来麻烦直接来这里交流: https://gitter.im/Jacksgong/JKeyboardPanelSwitch |
|
转而维护这个PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.