Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3693 #3702

Merged
merged 1 commit into from
Feb 6, 2018
Merged

fix #3693 #3702

merged 1 commit into from
Feb 6, 2018

Conversation

johannes-manner
Copy link
Collaborator

@johannes-manner johannes-manner commented Feb 6, 2018

Duplicated functionality, if file already exists. Previous implementation asks twice, if a file should be overriden.


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

Duplicated functionality, if file already exists. Asks twice, if a file should be overriden.
@johannes-manner johannes-manner changed the title fix https://github.com/JabRef/jabref/issues/3693 fix #3693 Feb 6, 2018
@tobiasdiez tobiasdiez merged commit dfd62b0 into JabRef:master Feb 6, 2018
Siedlerchr added a commit that referenced this pull request Feb 7, 2018
* upstream/master: (47 commits)
  Fix Google Scholar fetcher
  Use english for all LCID mappings #1851
  remove import preferences test mock import and convert to junit5
  fix #3693 (#3702)
  Fix space leads to jump in entry editor (#3699)
  Fix #3669
  Extract creation of the contents of FileAnnotationTabController
  Fix changelog
  Fix NPE
  Remove unnecessary file
  use processbuilder for calling external apps
  Fix color highlight of odd linked files
  Fixes #2964
  Fix koppor issues #3
  Allow spaces in DOIs
  Remove irrelevant log messages during XMP reading
  Adapt log4j configuration for cleaner junit tests #3511
  Eclipse Django style #3655
  Better code style for chained methods
  Update build.gradle
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants