Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISI import failure related to String index out of range: -1 #3669

Closed
elizagrames opened this issue Jan 27, 2018 · 4 comments
Closed

ISI import failure related to String index out of range: -1 #3669

elizagrames opened this issue Jan 27, 2018 · 4 comments
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. import status: waiting-for-feedback The submitter or other users need to provide more information about the issue

Comments

@elizagrames
Copy link

JabRef version 4.1 on Ubuntu 17.04 (and also the latest master build) fails to import ISI files (saved as .txt) if the field PS has no hyphen in it. Examples to repeat the issue are below. The error is "String index out of range: -1".

Will import:

PT J
DT Article
TI Example title.
PS 201-
BP 201
EP 299
LA English
AB Example abstract text.
ER

EF

Will not import:

PT J
DT Article
TI Example title.
PS 201
BP 201
EP 299
LA English
AB Example abstract text.
ER

EF
@tobiasdiez tobiasdiez added bug Confirmed bugs or reports that are very likely to be bugs import good first issue labels Jan 27, 2018
@koppor koppor added good first issue An issue intended for project-newcomers. Varies in difficulty. and removed good first issue labels Jan 29, 2018
@stefan-kolb
Copy link
Member

Is this format even still in use? I cannot find any documentation on the file format in the web?

@stefan-kolb
Copy link
Member

Also not sure what PS is used for. https://web.archive.org/web/20131031052339/http://wos.isitrial.com/help/helpprn.html
Does not say anything about such a field.

@stefan-kolb stefan-kolb added status: waiting-for-feedback The submitter or other users need to provide more information about the issue and removed bug Confirmed bugs or reports that are very likely to be bugs labels Feb 6, 2018
@elizagrames
Copy link
Author

ISI is still used by Web of Science if you export references for "other reference software." I have no idea why they include PS (it's the page range) but it prevents the import. The workaround I did was to just use sed to remove all lines beginning with PS.

@stefan-kolb
Copy link
Member

Thank you for your report 👍
This should be fixed in current master. Please try the latest build from http://builds.jabref.org/master.

Siedlerchr added a commit that referenced this issue Feb 7, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into sharelatex
ada867a 
* upstream/master: (47 commits)
  Fix Google Scholar fetcher
  Use english for all LCID mappings #1851
  remove import preferences test mock import and convert to junit5
  fix #3693 (#3702)
  Fix space leads to jump in entry editor (#3699)
  Fix #3669
  Extract creation of the contents of FileAnnotationTabController
  Fix changelog
  Fix NPE
  Remove unnecessary file
  use processbuilder for calling external apps
  Fix color highlight of odd linked files
  Fixes #2964
  Fix koppor issues #3
  Allow spaces in DOIs
  Remove irrelevant log messages during XMP reading
  Adapt log4j configuration for cleaner junit tests #3511
  Eclipse Django style #3655
  Better code style for chained methods
  Update build.gradle
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. import status: waiting-for-feedback The submitter or other users need to provide more information about the issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@koppor @stefan-kolb @tobiasdiez @elizagrames