-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Switch from Central Snapshots to JitPack #13434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
a5f64f7
f342853
e76d0e5
375a3c2
d921411
a15b2a3
9a83d99
2f7288f
119f6e7
442144f
4f89239
0612502
bf42fa4
67823a0
5e6617b
22a677d
7d7c00b
714a415
d242532
c84cb47
0877510
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,12 @@ | |
| //SOURCES ../jabsrv/src/main/java/org/jabref/http/dto/GsonFactory.java | ||
| //SOURCES ../jabsrv/src/main/java/org/jabref/http/JabrefMediaType.java | ||
| //SOURCES ../jabsrv/src/main/java/org/jabref/http/JabRefResourceLocator.java | ||
| //SOURCES ../jabsrv/src/main/java/org/jabref/http/server/cayw/CAYWResource.java | ||
| //SOURCES ../jabsrv/src/main/java/org/jabref/http/server/cayw/gui/CAYWEntry.java | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. GUI components are being sourced directly in the server package, violating the layered architecture principle. GUI code should be a gateway to logic code in org.jabref.logic. |
||
| //SOURCES ../jabsrv/src/main/java/org/jabref/http/server/cayw/gui/SearchDialog.java | ||
| //SOURCES ../jabsrv/src/main/java/org/jabref/http/server/cayw/gui/SearchField.java | ||
| //SOURCES ../jabsrv/src/main/java/org/jabref/http/server/cayw/gui/SearchResultContainer.java | ||
| //SOURCES ../jabsrv/src/main/java/org/jabref/http/server/cayw/gui/SelectedItemsContainer.java | ||
|
Comment on lines
+18
to
+21
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Including GUI-related code in server components violates layered architecture principles. GUI code should only be a gateway, and complex operations should be in org.jabref.logic.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cc @subhramit :) |
||
| //SOURCES ../jabsrv/src/main/java/org/jabref/http/server/CORSFilter.java | ||
| //SOURCES ../jabsrv/src/main/java/org/jabref/http/server/LibrariesResource.java | ||
| //SOURCES ../jabsrv/src/main/java/org/jabref/http/server/LibraryResource.java | ||
|
|
@@ -21,9 +27,15 @@ | |
| //SOURCES ../jabsrv/src/main/java/org/jabref/http/server/Server.java | ||
| //SOURCES ../jabsrv/src/main/java/org/jabref/http/server/services/FilesToServe.java | ||
|
|
||
| //REPOS mavencentral,mavencentralsnapshots=https://central.sonatype.com/repository/maven-snapshots/,s01oss=https://s01.oss.sonatype.org/content/repositories/snapshots/,oss=https://oss.sonatype.org/content/repositories,jitpack=https://jitpack.io,oss2=https://oss.sonatype.org/content/groups/public,ossrh=https://oss.sonatype.org/content/repositories/snapshots | ||
| //REPOS mavencentral,jitpack=https://jitpack.io | ||
|
|
||
| // TODO: ASCII things won't work, but we accept for now to keep things going | ||
| //DEPS com.ibm.icu:icu4j:72.1 | ||
|
|
||
| // disabled due to maven central issues | ||
| // DEPS org.jabref:jablib:6.+ | ||
|
Comment on lines
+35
to
+36
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Commented code should be removed as it serves no functional purpose. Git history should be used to track these changes instead of keeping commented code. |
||
| //DEPS com.github.jabref.jabref:jablib:main-SNAPSHOT | ||
|
|
||
| //DEPS org.jabref:jablib:6.+ | ||
| //DEPS info.picocli:picocli:4.7.7 | ||
| //DEPS org.jspecify:jspecify:1.0.0 | ||
|
|
||
|
|
||
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| jdk: | ||
| - openjdk24 | ||
| before_install: | ||
| - cd build-logic | ||
| - git clone https://github.com/koppor/java-module-packaging.git | ||
| - cd .. | ||
| install: | ||
| - ./gradlew :versions:publishToMavenLocal | ||
| - ./gradlew :jablib:publishToMavenLocal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented code with explanation should be removed. Version control history should be used to track these changes instead of keeping commented code in the source.