Switch from Central Snapshots to JitPack #13434
Conversation
koppor
changed the title
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
| //SOURCES ../jabsrv/src/main/java/org/jabref/http/server/cayw/gui/SearchDialog.java | ||
| //SOURCES ../jabsrv/src/main/java/org/jabref/http/server/cayw/gui/SearchField.java | ||
| //SOURCES ../jabsrv/src/main/java/org/jabref/http/server/cayw/gui/SearchResultContainer.java | ||
| //SOURCES ../jabsrv/src/main/java/org/jabref/http/server/cayw/gui/SelectedItemsContainer.java |
There was a problem hiding this comment.
Including GUI-related code in server components violates layered architecture principles. GUI code should only be a gateway, and complex operations should be in org.jabref.logic.
|
jitpack does not build the snapshot currently, but it works locally. I merge and hope for the best :) |
koppor
added
the
automerge
| // TODO: ASCII things won't work, but we accept for now to keep things going | ||
| //DEPS com.ibm.icu:icu4j:72.1 | ||
|
|
||
| // disabled due to maven central issues |
There was a problem hiding this comment.
Commented code with explanation should be removed. Version control history should be used to track these changes instead of keeping commented code in the source.
| //SOURCES ../jabsrv/src/main/java/org/jabref/http/JabrefMediaType.java | ||
| //SOURCES ../jabsrv/src/main/java/org/jabref/http/JabRefResourceLocator.java | ||
| //SOURCES ../jabsrv/src/main/java/org/jabref/http/server/cayw/CAYWResource.java | ||
| //SOURCES ../jabsrv/src/main/java/org/jabref/http/server/cayw/gui/CAYWEntry.java |
There was a problem hiding this comment.
GUI components are being sourced directly in the server package, violating the layered architecture principle. GUI code should be a gateway to logic code in org.jabref.logic.
| // disabled due to maven central issues | ||
| // DEPS org.jabref:jablib:6.+ |
There was a problem hiding this comment.
Commented code should be removed as it serves no functional purpose. Git history should be used to track these changes instead of keeping commented code.
|
Jitpack is even more unreliable
trag-bot[bot] ***@***.***> schrieb am Mi., 2. Juli 2025,
17:42:
… ***@***.***[bot]* commented on this pull request.
------------------------------
In .jbang/JabSrvLauncher.java
<#13434 (comment)>:
> +// disabled due to maven central issues
+// DEPS org.jabref:jablib:6.+
Commented dependency declarations create confusion and clutter the code.
Version history should be managed through git, not through commented code.
—
Reply to this email directly, view it on GitHub
<#13434 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACOFZCXZVJQYM4XNWORV7D3GP4YDAVCNFSM6AAAAACAUKRWNOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSNZZGY4DQNZTGQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Central Snapshots is down now and then. Therefore, trying jitpack.
Also a follow-up to #13319 to have the build clean:
jarfiles available on maven centralAlso follow-up to #13185 fixing JabSrvLauncher cc @palukku
Consequences:
jitpackis more reliable these days than maven central regarding snapshotsjitpackdoes not instantly build, but has some delays and skips versionsSteps to test
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)