Use setup-jbang action (instead of custom call of .sh script) #13208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koppor
added
the
automerge
jabref-machine
approved these changes
Jun 1, 2025
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
| pr = repo.getPullRequest(prNumber); | ||
| } | ||
|
|
||
| System.out.println("Determined PR URL is " + pr.getUrl()); |
There was a problem hiding this comment.
The added logging statement uses an exclamation mark at the end of the sentence, which is discouraged as it can be perceived as shouting. Use a period instead.
|
@trag-bot didn't find any issues in the code! ✅✨ |
Siedlerchr
approved these changes
Jun 1, 2025
auto-merge was automatically disabled
June 1, 2025 18:41
Pull Request is not mergeable
Siedlerchr
added a commit
to brandon-lau0/jabref
that referenced
this pull request
Jun 2, 2025
…or-test * upstream/main: (102 commits) Try to fix output Improve AI preferences UI and templates (JabRef#13202) Bump jablib/src/main/abbrv.jabref.org from `6926b83` to `333c2f1` (JabRef#13216) Bump jablib/src/main/resources/csl-styles from `8a2317a` to `c3df987` (JabRef#13215) Fixed search result focus handling (JabRef#13174) New Crowdin updates (JabRef#13214) Add Pseudonymization to CLI (JabRef#13158) Try parallel gource build Update gource.yml Fix position of checkout Preapre: Enable gradle configuration cache (JabRef#13212) Add yml as YAML extension (JabRef#13213) Fix wrong detection of issue numbers (JabRef#13211) Miscellaneous refactoring - II (JabRef#13197) Run Windows tests only on main (and on demand) (JabRef#13210) Fix porcelain for consistency check (JabRef#13209) Use setup-jbang action (instead of custom call of .sh script) (JabRef#13208) Add link to JabRef guru (JabRef#13207) Switch to gradlex for modularity (JabRef#13112) feat(ci-cd): change issue URL pattern (JabRef#13206) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refines
CheckoutPR.javato show more informationI wanted to show the current HEAD commit SHA, but this was not easily possible. Thus, I left "as is".
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)