Skip to content

Use setup-jbang action (instead of custom call of .sh script) #13208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koppor merged 6 commits into from
Jun 1, 2025
Merged

Use setup-jbang action (instead of custom call of .sh script) #13208

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
712b652
Use setup-jbang action (instead of custom call of .sh script)
koppor Jun 1, 2025
d370e47
Output PR URL
koppor Jun 1, 2025
11c8d43
Add "run-main"
koppor Jun 1, 2025
8eb109c
Fix run-main call
koppor Jun 1, 2025
14d4513
Output commit id
koppor Jun 1, 2025
3344140
Remove quotes
koppor Jun 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,7 @@ jobs:
submodules: 'false'
show-progress: 'false'
- name: Install JBang
run: |
curl -Ls https://sh.jbang.dev | bash -s - app setup
echo "$HOME/.jbang/bin" >> $GITHUB_PATH
uses: jbangdev/setup-jbang@main
- run: jbang build .jbang/CheckoutPR.java
- run: jbang build .jbang/CloneJabRef.java
- run: jbang build .jbang/JabKitLauncher.java
Expand Down
3 changes: 3 additions & 0 deletions .jbang/CheckoutPR.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ public static void main(String[] args) throws Exception {
pr = repo.getPullRequest(prNumber);
}

System.out.println("Determined PR URL is " + pr.getUrl());
Copy link

@trag-bot trag-bot bot Jun 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added logging statement uses an exclamation mark at the end of the sentence, which is discouraged as it can be perceived as shouting. Use a period instead.


if (pr.isMerged()) {
System.out.println("Pull request is already merged - checking out main branch...");
checkoutUpstreamMain();
Expand Down Expand Up @@ -145,6 +147,7 @@ public static void main(String[] args) throws Exception {
}

System.out.println("Checked out PR #" + pr.getNumber() + " (" + pr.getTitle() + ") to branch '" + localBranchName + "'.");
System.out.println("Checked out commit " + pr.getHead().getSha() + "'.");
}

private static void checkoutUpstreamMain() throws Exception {
Expand Down
3 changes: 3 additions & 0 deletions justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ run-jabkit *FLAGS:
run-jabsrv *FLAGS:
.\gg.cmd gradle :jabsrv-cli:run --args="{{FLAGS}}"

run-main:
just run main

run-pr pr-id:
just checkout-pr {{pr-id}}
just run-gui