Update fv3jedi repos from develop 2023/08/30#37
Merged
Conversation
climbfuji
force-pushed
the
feature/update_fv3jedi_from_develop_20230830
branch
from
6543946 to
39b348e
Compare
Collaborator
Author
|
CI tests passed after the latest push, ready to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Temporarily change the branches for the three fv3jedi repos to test updates from develop. ,Even though the branch names will get reverted, we may end up merging this just to update a few comments in
CMakeLists.txtTesting in CI: https://github.com/JCSDA/ufs-bundle/actions/runs/6026366347/job/16349119705
Also tested successfully on my macOS for UFS_APP ATM (but didn't try any of the other apps).
There is an issue for updating soca feature/ufs_dom, which has fallen behind (outside of the scope of this PR): JCSDA-internal/soca#951
Issue(s) addressed
ufs-bundle broken after recent JEDI merges
Dependencies
List the other PRs that this PR is dependent on:
Impact
ufs-bundle will be un-broken
Checklist